All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: rientjes@google.com, cl@linux-foundation.org, npiggin@suse.de,
	menage@google.com, dfults@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/7] cpuset writeback throttling
Date: Tue, 4 Nov 2008 13:16:37 -0800	[thread overview]
Message-ID: <20081104131637.68fbe055.akpm@linux-foundation.org> (raw)
In-Reply-To: <1225831988.7803.1939.camel@twins>

On Tue, 04 Nov 2008 21:53:08 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, 2008-11-04 at 12:47 -0800, Andrew Morton wrote:
> > On Thu, 30 Oct 2008 12:23:10 -0700 (PDT)
> > David Rientjes <rientjes@google.com> wrote:
> > 
> > > This is the revised cpuset writeback throttling patchset
> > 
> > I'm all confused about why this is a cpuset thing rather than a cgroups
> > thing.  What are the relationships here?
> > 
> > I mean, writeback throttling _should_ operate upon a control group
> > (more specifically: a memcg), yes?  I guess you're assuming a 1:1
> > relationship here?
> 
> I think the main reason is that we have per-node vmstats so the cpuset
> extention is relatively easy. Whereas we do not currently maintain
> vmstats on a cgroup level - although I imagine that could be remedied.

It didn't look easy to me - it added a lot more code in places which are
already wicked complex.

I'm trying to understand where this is all coming from and what fits
into where.  Fiddling with a cpuset's mems_allowed for purposes of
memory partitioning is all nasty 2007 technology, isn't it?  Does a raw
cpuset-based control such as this have a future?



  parent reply	other threads:[~2008-11-04 21:17 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 19:23 [patch 0/7] cpuset writeback throttling David Rientjes
2008-10-30 19:23 ` [patch 1/7] cpusets: add dirty map to struct address_space David Rientjes
2008-11-04 21:09   ` Andrew Morton
2008-11-04 21:20     ` Christoph Lameter
2008-11-04 21:42       ` Andrew Morton
2008-10-30 19:23 ` [patch 2/7] pdflush: allow the passing of a nodemask parameter David Rientjes
2008-10-30 19:23 ` [patch 3/7] mm: make page writeback obey cpuset constraints David Rientjes
2008-10-30 19:23 ` [patch 4/7] mm: cpuset aware reclaim writeout David Rientjes
2008-10-30 19:23 ` [patch 5/7] mm: throttle writeout with cpuset awareness David Rientjes
2008-10-30 19:23 ` [patch 6/7] cpusets: per cpuset dirty ratios David Rientjes
2008-10-30 19:23 ` [patch 7/7] cpusets: update documentation for writeback throttling David Rientjes
2008-10-30 21:08 ` [patch 0/7] cpuset " Dave Chinner
2008-10-30 21:33   ` Christoph Lameter
2008-10-30 22:03     ` Dave Chinner
2008-10-31 13:47       ` Christoph Lameter
2008-10-31 16:36       ` David Rientjes
2008-11-04 20:47 ` Andrew Morton
2008-11-04 20:53   ` Peter Zijlstra
2008-11-04 20:58     ` Christoph Lameter
2008-11-04 21:10     ` David Rientjes
2008-11-04 21:16     ` Andrew Morton [this message]
2008-11-04 21:21       ` Peter Zijlstra
2008-11-04 21:50         ` Andrew Morton
2008-11-04 22:17           ` Christoph Lameter
2008-11-04 22:35             ` Andrew Morton
2008-11-04 22:52               ` Christoph Lameter
2008-11-04 23:36                 ` Andrew Morton
2008-11-05  1:31                   ` KAMEZAWA Hiroyuki
2008-11-05  3:09                     ` Andrew Morton
2008-11-05  2:45                   ` Christoph Lameter
2008-11-05  3:05                     ` Andrew Morton
     [not found]                       ` <20081104190505.769b93ec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-11-05  4:31                         ` KAMEZAWA Hiroyuki
2008-11-05  4:31                           ` KAMEZAWA Hiroyuki
2008-11-10  9:02                           ` Andrea Righi
     [not found]                             ` <4917F895.109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-10 10:02                               ` David Rientjes
2008-11-10 10:02                                 ` David Rientjes
2008-11-05 13:52                       ` Christoph Lameter
2008-11-05 18:41                         ` Andrew Morton
2008-11-05 20:21                           ` Christoph Lameter
     [not found]                             ` <Pine.LNX.4.64.0811051415360.31450-dRBSpnHQED8AvxtiuMwx3w@public.gmane.org>
2008-11-05 20:31                               ` Andrew Morton
2008-11-05 20:31                                 ` Andrew Morton
2008-11-05 20:40                                 ` Christoph Lameter
2008-11-05 20:56                                   ` Andrew Morton
2008-11-05 21:28                                     ` Christoph Lameter
2008-11-05 21:55                                     ` Paul Menage
2008-11-05 22:04                                     ` David Rientjes
2008-11-06  1:34                                       ` KAMEZAWA Hiroyuki
2008-11-06 20:35                                         ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081104131637.68fbe055.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=dfults@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=npiggin@suse.de \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.