All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: hal-0.5.11 fails with external toolchain/SDK
Date: Tue, 04 Nov 2008 14:48:12 -0500	[thread overview]
Message-ID: <20081104194812.GA18457@denix.org> (raw)
In-Reply-To: <200811041213.25205.zecke@selfish.org>

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Tue, Nov 04, 2008 at 12:13:24PM +0100, Holger Freyther wrote:
> On Tuesday 04 November 2008 01:55:12 Denys Dmytriyenko wrote:
> > Hi,
> >
> > New hal-0.5.11 from OpenMoko breaks builds with external-toolchain/SDK, as
> > it hardcodes linux/input.h like this:
> 
> It is Openmoko, and I did add it.
> 
> what about something among the lines of?
> 
> echo "#include <linux/input.h>" | cpp | less | grep "linux\/input.h"

Thanks for the hint. I was able to fix it, so it finds the right linux/input.h 
file even with external-toolchain/SDK.

The patch is attached to the ticket #4799 and this email. I was not able to 
call autoreconf, as it was giving too many problems. autotools_do_configure 
worked fine, but unfortunately, it doesn't take parameters to pass to the 
oe_runconf, so I had to call it again with the correct --with flag. Let me 
know if it's Ok or not. Thanks.

-- 
Denys

[-- Attachment #2: hal-0.5.11-linux-input-h-sdk.patch --]
[-- Type: text/plain, Size: 761 bytes --]

diff --git a/packages/hal/hal_0.5.11.bb b/packages/hal/hal_0.5.11.bb
index e93ad64..432af22 100644
--- a/packages/hal/hal_0.5.11.bb
+++ b/packages/hal/hal_0.5.11.bb
@@ -1,8 +1,15 @@
 require hal.inc
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI += " file://hal-right-input-h.patch;patch=1 \
              file://fix-configure.diff;patch=1"
 
-EXTRA_OECONF += "--with-linux-input-header=${STAGING_INCDIR}/linux/input.h"
+# The following code finds the right linux/input.h,
+# which also works with external-toolchain/SDK
+do_configure() {
+	linux_input_h=`echo "#include <linux/input.h>" | ${CPP} - | \
+		grep "linux\/input.h" | head -n 1 | awk -F '"' '{print $2}'`
+	autotools_do_configure
+	oe_runconf --with-linux-input-header=${linux_input_h}
+}

  reply	other threads:[~2008-11-04 19:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  0:55 hal-0.5.11 fails with external toolchain/SDK Denys Dmytriyenko
2008-11-04 11:13 ` Holger Freyther
2008-11-04 19:48   ` Denys Dmytriyenko [this message]
2008-11-06 23:12     ` Denys Dmytriyenko
2008-11-07  9:11       ` Koen Kooi
2008-11-11  1:37         ` Denys Dmytriyenko
2008-11-14 22:24 ` Koen Kooi
2008-11-15 11:45   ` Michael 'Mickey' Lauer
2008-11-15 14:53     ` Philip Balister
2008-11-15 15:30       ` Michael 'Mickey' Lauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081104194812.GA18457@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.