From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.redhat.com ([66.187.237.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KxjaH-00057B-AJ for kexec@lists.infradead.org; Wed, 05 Nov 2008 14:42:13 +0000 Date: Wed, 5 Nov 2008 09:41:44 -0500 From: Vivek Goyal Subject: Re: [PATCH 09/16] kdump: Hook emergency_virt_disable() on crash shutdown code Message-ID: <20081105144144.GC8993@redhat.com> References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-10-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1225810364-8990-10-git-send-email-ehabkost@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Eduardo Habkost Cc: Andrew Morton , kvm@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Avi Kivity , Ingo Molnar , Andrey Borzenkov , mingo@redhat.com, "Eric W. Biederman" On Tue, Nov 04, 2008 at 12:52:37PM -0200, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > arch/x86/kernel/crash.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > index d84a852..87780ba 100644 > --- a/arch/x86/kernel/crash.c > +++ b/arch/x86/kernel/crash.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #include > > @@ -49,6 +50,7 @@ static void kdump_nmi_callback(int cpu, struct die_args *args) > #endif > crash_save_cpu(regs, cpu); > > + emergency_virt_disable(); > disable_local_APIC(); > } > > @@ -80,6 +82,7 @@ void native_machine_crash_shutdown(struct pt_regs *regs) > local_irq_disable(); > > kdump_nmi_shootdown_cpus(); > + emergency_virt_disable(); Hi Eduardo, It might be a good idea to put a 2-3 line comment saying why it is imporatant to disable virtualization here before we continue. Thanks Vivek _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755802AbYKEOmv (ORCPT ); Wed, 5 Nov 2008 09:42:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752111AbYKEOmm (ORCPT ); Wed, 5 Nov 2008 09:42:42 -0500 Received: from mx2.redhat.com ([66.187.237.31]:50604 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbYKEOml (ORCPT ); Wed, 5 Nov 2008 09:42:41 -0500 Date: Wed, 5 Nov 2008 09:41:44 -0500 From: Vivek Goyal To: Eduardo Habkost Cc: Avi Kivity , Ingo Molnar , "Eric W. Biederman" , Simon Horman , Andrew Morton , Haren Myneni , Andrey Borzenkov , mingo@redhat.com, "Rafael J. Wysocki" , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/16] kdump: Hook emergency_virt_disable() on crash shutdown code Message-ID: <20081105144144.GC8993@redhat.com> References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-10-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1225810364-8990-10-git-send-email-ehabkost@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2008 at 12:52:37PM -0200, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > arch/x86/kernel/crash.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > index d84a852..87780ba 100644 > --- a/arch/x86/kernel/crash.c > +++ b/arch/x86/kernel/crash.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #include > > @@ -49,6 +50,7 @@ static void kdump_nmi_callback(int cpu, struct die_args *args) > #endif > crash_save_cpu(regs, cpu); > > + emergency_virt_disable(); > disable_local_APIC(); > } > > @@ -80,6 +82,7 @@ void native_machine_crash_shutdown(struct pt_regs *regs) > local_irq_disable(); > > kdump_nmi_shootdown_cpus(); > + emergency_virt_disable(); Hi Eduardo, It might be a good idea to put a 2-3 line comment saying why it is imporatant to disable virtualization here before we continue. Thanks Vivek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH 09/16] kdump: Hook emergency_virt_disable() on crash shutdown code Date: Wed, 5 Nov 2008 09:41:44 -0500 Message-ID: <20081105144144.GC8993@redhat.com> References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-10-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Avi Kivity , Ingo Molnar , Andrey Borzenkov , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Eric W. Biederman" To: Eduardo Habkost Return-path: Content-Disposition: inline In-Reply-To: <1225810364-8990-10-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org On Tue, Nov 04, 2008 at 12:52:37PM -0200, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > arch/x86/kernel/crash.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > index d84a852..87780ba 100644 > --- a/arch/x86/kernel/crash.c > +++ b/arch/x86/kernel/crash.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #include > > @@ -49,6 +50,7 @@ static void kdump_nmi_callback(int cpu, struct die_args *args) > #endif > crash_save_cpu(regs, cpu); > > + emergency_virt_disable(); > disable_local_APIC(); > } > > @@ -80,6 +82,7 @@ void native_machine_crash_shutdown(struct pt_regs *regs) > local_irq_disable(); > > kdump_nmi_shootdown_cpus(); > + emergency_virt_disable(); Hi Eduardo, It might be a good idea to put a 2-3 line comment saying why it is imporatant to disable virtualization here before we continue. Thanks Vivek