From: Jianjun Kong <jianjun@zeuux.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH] nets: fix problem of using lock
Date: Thu, 6 Nov 2008 18:41:03 +0800 [thread overview]
Message-ID: <20081106104103.GA29787@ubuntu> (raw)
net/core/skbuff.c: void skb_queue_purge(struct sk_buff_head *list)
This function should takes the the list lock, because the operation to
this list shoule be atomic. And __skb_queue_purge() (in
include/linux/skbuff.c) real delete the buffers in the list.
Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
---
net/core/skbuff.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ebb6b94..3b89fb1 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1834,9 +1834,11 @@ struct sk_buff *skb_dequeue_tail(struct sk_buff_head *list)
*/
void skb_queue_purge(struct sk_buff_head *list)
{
- struct sk_buff *skb;
- while ((skb = skb_dequeue(list)) != NULL)
- kfree_skb(skb);
+ unsigned long flags;
+
+ spin_lock_irqsave(&list->lock, flags);
+ __skb_queue_purge(list);
+ spin_unlock_irqrestore(&list->lock, flags);
}
/**
--
1.5.6.3
next reply other threads:[~2008-11-06 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 10:41 Jianjun Kong [this message]
2008-11-10 21:35 ` [PATCH] nets: fix problem of using lock David Miller
2008-11-11 1:34 ` Jianjun Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106104103.GA29787@ubuntu \
--to=jianjun@zeuux.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.