From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <Tim.Deegan@citrix.com>
Subject: Re: debuggers and hap_gva_to_gfn() in guest_walk.c
Date: Thu, 6 Nov 2008 10:51:57 +0000
Message-ID: <20081106105157.GC25331@york.uk.xensource.com>
References: <491213BF.8040300@oracle.com>
	<C537C715.1EEB2%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <C537C715.1EEB2%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: mukesh.rathor@oracle.com, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

At 21:56 +0000 on 05 Nov (1225922197), Keir Fraser wrote:
> This looks like a bug in hap_gva_to_gfn(). It should probably be using
> gfn_to_mfn() rather than gfn_to_mfn_current(). Tim, can you confirm?

In the current codebase, it's correct (all callers of paging_gva_to_gfn()
call with v == current) but changing it to use gfn_to_mfn() seems
more correcter.

Tim.

> On 5/11/08 21:44, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
> 
> > 
> > Debugger/s would like to keep it's #ifdefs in xen minimal. Following would
> > help...
> > 
> > hap_gva_to_gfn():
> > 
> > 
> > +   if (v== current)
> >         mfn = mfn_x(gfn_to_mfn_current(gpfn, &p2mt));
> > +   else
> > +      mfn = mfn_x(gfn_to_mfn_foreign(v->domain, gpfn, &p2mt));
> > 
> > 
> > Thanks,
> > Mukesh
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> 
> 

-- 
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]