From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.redhat.com ([66.187.237.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1Ky4AZ-0001Bq-E4 for kexec@lists.infradead.org; Thu, 06 Nov 2008 12:41:03 +0000 Date: Thu, 6 Nov 2008 10:40:31 -0200 From: Eduardo Habkost Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI" Message-ID: <20081106124031.GO5247@blackpad> References: <1225915018-6548-1-git-send-email-ehabkost@redhat.com> <1225915018-6548-16-git-send-email-ehabkost@redhat.com> <20081106071445.GI15731@elte.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081106071445.GI15731@elte.hu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Ingo Molnar Cc: Andrew Morton , kvm@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Avi Kivity , Andrey Borzenkov , mingo@redhat.com, Vivek Goyal , "Eric W. Biederman" On Thu, Nov 06, 2008 at 08:14:45AM +0100, Ingo Molnar wrote: > > * Eduardo Habkost wrote: > > > This reverts commit c7ffa6c26277b403920e2255d10df849bd613380. > > > > Now that we have the hooks to disable virtualization on > > emergency_restart(), we can get back to the BOOT_KBD reboot_type default. > > > > Signed-off-by: Eduardo Habkost > > hm, why revert this? There's nothing wrong with the ACPI reboot > method, it's just that we surprise the BIOS by exiting with an unclean > VMX state in certain circumstances. > > if the ACPI reboot method does not work we do the KBD method as the > next thing in the reboot chain. I suppose there are cases where the new default broke without KVM, and the suggestion was to disable VMX before rebooting instead of changing the default. Avi changed the default because on some machines reboot=kbd breaks when VMX is enabled, but the regressions caused by the new default doesn't necessarily involve VMX. Andrey Borzenkov's patch, for example, adds a new DMI entry because reboot=acpi breaks his keyboard (even without KVM, I guess). Andrey, was that the case? -- Eduardo _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754278AbYKFMlj (ORCPT ); Thu, 6 Nov 2008 07:41:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753512AbYKFMlb (ORCPT ); Thu, 6 Nov 2008 07:41:31 -0500 Received: from mx2.redhat.com ([66.187.237.31]:44821 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbYKFMla (ORCPT ); Thu, 6 Nov 2008 07:41:30 -0500 Date: Thu, 6 Nov 2008 10:40:31 -0200 From: Eduardo Habkost To: Ingo Molnar Cc: Avi Kivity , "Eric W. Biederman" , Simon Horman , Andrew Morton , Vivek Goyal , Haren Myneni , Andrey Borzenkov , mingo@redhat.com, "Rafael J. Wysocki" , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI" Message-ID: <20081106124031.GO5247@blackpad> References: <1225915018-6548-1-git-send-email-ehabkost@redhat.com> <1225915018-6548-16-git-send-email-ehabkost@redhat.com> <20081106071445.GI15731@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081106071445.GI15731@elte.hu> X-Fnord: you can see the fnord User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 06, 2008 at 08:14:45AM +0100, Ingo Molnar wrote: > > * Eduardo Habkost wrote: > > > This reverts commit c7ffa6c26277b403920e2255d10df849bd613380. > > > > Now that we have the hooks to disable virtualization on > > emergency_restart(), we can get back to the BOOT_KBD reboot_type default. > > > > Signed-off-by: Eduardo Habkost > > hm, why revert this? There's nothing wrong with the ACPI reboot > method, it's just that we surprise the BIOS by exiting with an unclean > VMX state in certain circumstances. > > if the ACPI reboot method does not work we do the KBD method as the > next thing in the reboot chain. I suppose there are cases where the new default broke without KVM, and the suggestion was to disable VMX before rebooting instead of changing the default. Avi changed the default because on some machines reboot=kbd breaks when VMX is enabled, but the regressions caused by the new default doesn't necessarily involve VMX. Andrey Borzenkov's patch, for example, adds a new DMI entry because reboot=acpi breaks his keyboard (even without KVM, I guess). Andrey, was that the case? -- Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI" Date: Thu, 6 Nov 2008 10:40:31 -0200 Message-ID: <20081106124031.GO5247@blackpad> References: <1225915018-6548-1-git-send-email-ehabkost@redhat.com> <1225915018-6548-16-git-send-email-ehabkost@redhat.com> <20081106071445.GI15731@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Avi Kivity , Andrey Borzenkov , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Vivek Goyal , "Eric W. Biederman" To: Ingo Molnar Return-path: Content-Disposition: inline In-Reply-To: <20081106071445.GI15731-X9Un+BFzKDI@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Nov 06, 2008 at 08:14:45AM +0100, Ingo Molnar wrote: > > * Eduardo Habkost wrote: > > > This reverts commit c7ffa6c26277b403920e2255d10df849bd613380. > > > > Now that we have the hooks to disable virtualization on > > emergency_restart(), we can get back to the BOOT_KBD reboot_type default. > > > > Signed-off-by: Eduardo Habkost > > hm, why revert this? There's nothing wrong with the ACPI reboot > method, it's just that we surprise the BIOS by exiting with an unclean > VMX state in certain circumstances. > > if the ACPI reboot method does not work we do the KBD method as the > next thing in the reboot chain. I suppose there are cases where the new default broke without KVM, and the suggestion was to disable VMX before rebooting instead of changing the default. Avi changed the default because on some machines reboot=kbd breaks when VMX is enabled, but the regressions caused by the new default doesn't necessarily involve VMX. Andrey Borzenkov's patch, for example, adds a new DMI entry because reboot=acpi breaks his keyboard (even without KVM, I guess). Andrey, was that the case? -- Eduardo