From: Tino Keitel <tino.keitel@tikei.de>
To: ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3
Date: Thu, 6 Nov 2008 16:32:15 +0100 [thread overview]
Message-ID: <20081106153215.GA23739@x61> (raw)
In-Reply-To: <20081106141121.GB23278@khazad-dum.debian.net>
On Thu, Nov 06, 2008 at 12:11:21 -0200, Henrique de Moraes Holschuh wrote:
[...]
> and must set it to the higher of (saved, current) using this rule:
>
> fulll-speed > 7 > AUTO.
Maybe the level values should be changed to describe this order.
Currently, it's AUTO (0x80) > full-speed (0x40) > 7. There are already
29(!) functions just for the fan handling, so there should be enough
room for a bit of abstraction. :-) I think it could have the benefit of code
which is easier to read and maintain. Correct me if I'm wrong.
Regards,
Tino
next prev parent reply other threads:[~2008-11-06 15:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 7:33 Fan level 7 after resume wit 2.6.28-rc3 Tino Keitel
2008-11-05 7:47 ` [ibm-acpi-devel] " Tino Keitel
2008-11-05 12:26 ` Henrique de Moraes Holschuh
2008-11-05 13:02 ` Tino Keitel
2008-11-05 13:08 ` Tino Keitel
2008-11-05 16:24 ` Henrique de Moraes Holschuh
2008-11-06 0:35 ` Tino Keitel
2008-11-06 8:23 ` Tino Keitel
2008-11-06 14:21 ` Henrique de Moraes Holschuh
2008-11-08 22:45 ` Rafael J. Wysocki
2008-11-09 11:30 ` Henrique de Moraes Holschuh
[not found] ` <20081109113011.GB8329-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2008-11-09 12:54 ` [GIT PATCH] thinkpad-acpi regression fix for 2.6.28-rc Henrique de Moraes Holschuh
2008-11-09 12:54 ` Henrique de Moraes Holschuh
2008-11-09 13:22 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2008-11-09 12:54 ` [PATCH] ACPI: thinkpad-acpi: fix fan sleep/resume path Henrique de Moraes Holschuh
[not found] ` <1226235242-11130-2-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2008-11-12 5:02 ` Len Brown
2008-11-12 5:02 ` Len Brown
2008-11-17 2:14 ` Henrique de Moraes Holschuh
2008-11-17 14:26 ` [ibm-acpi-devel] " Tino Keitel
2008-11-13 7:26 ` [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3 Pavel Machek
2008-11-06 14:11 ` Henrique de Moraes Holschuh
2008-11-06 15:22 ` Tino Keitel
2008-11-06 15:31 ` Henrique de Moraes Holschuh
2008-11-06 15:32 ` Tino Keitel [this message]
2008-11-06 21:15 ` Henrique de Moraes Holschuh
2008-11-05 13:45 ` Tino Keitel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106153215.GA23739@x61 \
--to=tino.keitel@tikei.de \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.