From: "Frank Ch. Eigler" <fche@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, alan@redhat.com,
jbaron@redhat.com
Subject: Re: [PATCH] ftrace: add an fsync tracer
Date: Thu, 6 Nov 2008 17:14:27 -0500 [thread overview]
Message-ID: <20081106221426.GD20928@redhat.com> (raw)
In-Reply-To: <20081106215310.GA15163@Krystal>
Hi -
On Thu, Nov 06, 2008 at 04:53:11PM -0500, Mathieu Desnoyers wrote:
> [...]
> > Something like
> >
> > DEFINE_TRACE_FMT(sched_switch,
> > TPPROTO(struct rq *rq, struct task_struct *prev,
> > struct task_struct *next),
> > TPARGS(rq, prev, next),
> > TPFMT("%d to %d\n", prev->pid, next->pid));
> >
> > Which would be similar to attaching a trace_mark() to the trace point
> > and can in these cases save a lot of lines of code.
> >
> > Both lttng and the ftrace event tracer can use these default text
> > strings.
>
> Argh. No, please. Doing this would end up exposing the inner kernel API
> (the tracepoints) directly to userspace. [...]
Arjan asked for something to send formatted strings to tracing buffers
that are consumed by user space. Whether internally that is done by
markers, or by tracepoints converted to markers, or by tracepoints
with custom ftrace_printf-y code, is indistinguishable to the user.
Can you be specific in what way any of that is exposing an "API
directly to userspace"?
- FChE
next prev parent reply other threads:[~2008-11-06 22:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 17:49 [PATCH] ftrace: add an fsync tracer Arjan van de Ven
2008-11-05 19:43 ` Marcin Slusarz
2008-11-05 20:36 ` Arjan van de Ven
2008-11-06 7:20 ` Ingo Molnar
2008-11-06 12:55 ` Peter Zijlstra
2008-11-06 13:28 ` Frédéric Weisbecker
2008-11-06 14:06 ` Arjan van de Ven
2008-11-06 14:19 ` Peter Zijlstra
2008-11-06 14:31 ` Arjan van de Ven
2008-11-06 14:50 ` Peter Zijlstra
2008-11-06 15:01 ` Arjan van de Ven
2008-11-06 15:34 ` Steven Rostedt
2008-11-06 17:45 ` Arjan van de Ven
2008-11-06 20:19 ` Frank Ch. Eigler
2008-11-06 20:29 ` Peter Zijlstra
2008-11-06 20:57 ` Frank Ch. Eigler
2008-11-06 21:18 ` Jason Baron
2008-11-06 21:53 ` Mathieu Desnoyers
2008-11-06 22:14 ` Frank Ch. Eigler [this message]
2008-11-06 22:25 ` Mathieu Desnoyers
2008-11-06 23:25 ` Frank Ch. Eigler
2008-11-07 4:25 ` Arjan van de Ven
2008-11-07 5:12 ` Mathieu Desnoyers
2008-11-06 21:13 ` Arjan van de Ven
2008-11-06 21:20 ` Frank Ch. Eigler
2008-11-06 14:14 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106221426.GD20928@redhat.com \
--to=fche@redhat.com \
--cc=alan@redhat.com \
--cc=arjan@infradead.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.