From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 12/12] lockd: remove redundant rpc_shutdown_client() Date: Thu, 6 Nov 2008 17:22:33 -0500 Message-ID: <20081106222233.GH24916@fieldses.org> References: <1225915611-2401-6-git-send-email-bfields@citi.umich.edu> <1225915611-2401-7-git-send-email-bfields@citi.umich.edu> <1225915611-2401-8-git-send-email-bfields@citi.umich.edu> <1225915611-2401-9-git-send-email-bfields@citi.umich.edu> <1225915611-2401-10-git-send-email-bfields@citi.umich.edu> <1225915611-2401-11-git-send-email-bfields@citi.umich.edu> <1225915611-2401-12-git-send-email-bfields@citi.umich.edu> <20081106071733.6d4983ce@barsoom.rdu.redhat.com> <20081106221057.GF24916@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff Layton , linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mail.fieldses.org ([66.93.2.214]:53248 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbYKFWX7 (ORCPT ); Thu, 6 Nov 2008 17:23:59 -0500 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Nov 06, 2008 at 05:21:05PM -0500, Chuck Lever wrote: > > On Nov 6, 2008, at Nov 6, 2008, 5:10 PM, J. Bruce Fields wrote: > >> On Thu, Nov 06, 2008 at 07:17:33AM -0500, Jeff Layton wrote: >>> On Wed, 5 Nov 2008 15:06:51 -0500 >>> "J. Bruce Fields" wrote: >>> >>>> These clients will all be shut down by nlm_destroy_host() when we do >>>> garbage collection a little later, so this is redundant. >>>> >>>> XXX: Ask Jeff Layton why he added this again? >>>> >>>> Signed-off-by: J. Bruce Fields >>>> --- >>>> fs/lockd/host.c | 8 +------- >>>> 1 files changed, 1 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/fs/lockd/host.c b/fs/lockd/host.c >>>> index 73c2be2..0387c6b 100644 >>>> --- a/fs/lockd/host.c >>>> +++ b/fs/lockd/host.c >>>> @@ -602,14 +602,8 @@ static void expire_hosts(struct host_table >>>> *table) >>>> struct hlist_node *pos; >>>> struct nlm_host *host; >>>> >>>> - dprintk("lockd: nuking all hosts...\n"); >>>> - for_each_host(host, pos, chain, table) { >>>> + for_each_host(host, pos, chain, table) >>>> host->h_expires = jiffies - 1; >>>> - if (host->h_rpcclnt) { >>>> - rpc_shutdown_client(host->h_rpcclnt); >>>> - host->h_rpcclnt = NULL; >>>> - } >>>> - } >>>> } >>>> >>>> /* >>> >>> Thank goodness for my OC commenting in the BZ I was using to track >>> this! >>> >>> https://bugzilla.redhat.com/show_bug.cgi?id=254195#c4 >> >> We should try to get that kind of comment out of scattered bugzillas >> and >> in to the code.... > > Done. I talked with Jeff today, who explained why this extra RPC client > shutdown code is here. A documentation patch will be included in the > series that splits the host cache. Cool, thanks.--b.