From: "Jörn Engel" <joern@logfs.org>
To: Warren Turkal <wt@penguintechs.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH] Fix journal detection on HFS+.
Date: Fri, 7 Nov 2008 09:32:51 +0100 [thread overview]
Message-ID: <20081107083250.GA29200@logfs.org> (raw)
In-Reply-To: <1225957463-29519-3-git-send-email-wt@penguintechs.org>
On Wed, 5 November 2008 23:44:23 -0800, Warren Turkal wrote:
>
> -hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o btree.o \
> - bnode.o brec.o bfind.o tables.o unicode.o wrapper.o bitmap.o part_tbl.o
> +hfsplus-objs := super.o options.o inode.o ioctl.o extents.o catalog.o dir.o \
> + btree.o bnode.o brec.o bfind.o tables.o unicode.o wrapper.o \
> + bitmap.o part_tbl.o journal.o
Didn't check-read your patch? Remove, please.
> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
> index f027a90..9018d2d 100644
> --- a/fs/hfsplus/hfsplus_fs.h
> +++ b/fs/hfsplus/hfsplus_fs.h
> @@ -421,4 +421,6 @@ static inline struct hfsplus_inode_info *HFSPLUS_I(struct inode *inode)
>
> #define kdev_t_to_nr(x) (x)
>
> +bool hfsp_vol_has_journal(struct hfsplus_vh *vhdr);
> +
The function is only ever used in super.c. Just leave it in the same
file and make it static.
Jörn
--
Premature optimization is the root of all evil.
-- Donald Knuth
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-07 8:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 8:00 hfsplus journal detection Warren Turkal
2008-11-05 8:00 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-05 8:00 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-05 10:40 ` Jörn Engel
2008-11-05 14:09 ` Christoph Hellwig
2008-11-06 7:44 ` hfsplus journal detection - next try Warren Turkal
2008-11-06 7:44 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-06 7:44 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-07 8:32 ` Jörn Engel [this message]
2008-11-07 18:01 ` Warren Turkal
2008-11-08 11:09 ` Jörn Engel
2008-11-09 5:27 ` Warren Turkal
2008-11-09 11:02 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2008-11-08 8:55 hfsplus journal detection - try 3 Warren Turkal
2008-11-08 8:55 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-08 8:55 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-11 20:56 hfsplus journal detection - try 4 Warren Turkal
2008-11-11 20:56 ` [PATCH] Identify journal info block in volume header Warren Turkal
2008-11-11 20:56 ` [PATCH] Fix journal detection on HFS+ Warren Turkal
2008-11-19 22:51 ` Andrew Morton
2008-11-20 1:01 ` Warren Turkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107083250.GA29200@logfs.org \
--to=joern@logfs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wt@penguintechs.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.