From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: rewrite SCHED_CPUMASK_ALLOC
Date: Fri, 7 Nov 2008 10:30:50 +0100 [thread overview]
Message-ID: <20081107093050.GC7787@elte.hu> (raw)
In-Reply-To: <49140456.8020400@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> Sorry, you are right - keep the SCHED_CPUMASK_DECLARE() macro please.
> >
> > But the other macros can become an inline function just fine, correct?
> >
>
> Yes, but sched_cpumask_alloc() should be declared this way:
> void sched_cpumask_alloc(struct **allmasks)
> but not:
> struct *allmasks sched_cpumask_alloc(void)
>
> Because the latter is not workable for <128 CPUs case.
>
> (patch is based on [PATCH] sched: fix memory leak in a failing path)
applied to tip/sched/core, thanks!
Ingo
prev parent reply other threads:[~2008-11-07 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 5:50 [PATCH] sched: rewrite SCHED_CPUMASK_ALLOC Li Zefan
2008-11-06 8:00 ` Ingo Molnar
2008-11-07 7:17 ` Li Zefan
2008-11-07 8:16 ` Ingo Molnar
2008-11-07 9:03 ` Li Zefan
2008-11-07 9:30 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107093050.GC7787@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.