From: Andrew Morton <akpm@linux-foundation.org>
To: Steve Kemp <steve.30-11-2008.date@steve.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Many headers included multiple times
Date: Fri, 7 Nov 2008 13:04:35 -0800 [thread overview]
Message-ID: <20081107130435.884be9f5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081101111538.GA16874@steve.org.uk>
On Sat, 1 Nov 2008 11:15:38 +0000
Steve Kemp <steve.30-11-2008.date@steve.org.uk> wrote:
> There are many source files which include the same header multiple
> times. Minimal initial patch included here, will submit the rest
> shortly if there is interest.
>
> Quick tool to detect these: http://www.steve.org.uk/Software/kernel/
I flee in terror from patches like this because of the risk that
someone else will delete the _other_ #include, and this patch still
applies OK, so we end up removing both #includes and things break.
This has happened before.
Thought: if the patch were to delete one #include and to then move the
other one to a different position in the #include order then this
couldn't happen.
prev parent reply other threads:[~2008-11-07 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 11:15 [PATCH] Many headers included multiple times Steve Kemp
2008-11-07 21:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107130435.884be9f5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.30-11-2008.date@steve.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.