From: Felipe Balbi <me@felipebalbi.com>
To: "Stanley.Miao" <stanley.miao@windriver.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/3] OMAP: Update the search() interface of omap_hdq.
Date: Fri, 7 Nov 2008 17:52:13 +0200 [thread overview]
Message-ID: <20081107155212.GG21860@frodo> (raw)
In-Reply-To: <1226065287-3066-2-git-send-email-stanley.miao@windriver.com>
On Fri, Nov 07, 2008 at 09:41:25PM +0800, Stanley.Miao wrote:
> /* W1 search callback function */
> -static void omap_w1_search_bus(void *_hdq, u8 search_type,
> - w1_slave_found_callback slave_found)
> +static void omap_w1_search_bus(void *_hdq, struct w1_master *master_dev,
> + u8 search_type,w1_slave_found_callback slave_found)
Please fix this:
ERROR: space required after that ',' (ctx:VxV)
#74: FILE: drivers/w1/masters/omap_hdq.c:241:
+ u8 search_type,w1_slave_found_callback slave_found)
--
balbi
next prev parent reply other threads:[~2008-11-07 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 13:41 [PATCH 0/3] OMAP: Make OMAP LDP boot succussfuly Stanley.Miao
2008-11-07 13:41 ` [PATCH 1/3] OMAP: Update the search() interface of omap_hdq Stanley.Miao
2008-11-07 13:41 ` [PATCH 2/3] OMAP_LDP: Add Ethernet device support to make ldp boot succeess Stanley.Miao
2008-11-07 13:41 ` [PATCH 3/3] OMAP_LDP: Add keypad support on ZOOM SDK Stanley.Miao
2008-11-07 16:02 ` Felipe Balbi
2008-11-07 15:55 ` [PATCH 2/3] OMAP_LDP: Add Ethernet device support to make ldp boot succeess Felipe Balbi
2008-11-07 15:52 ` Felipe Balbi [this message]
2008-11-07 15:53 ` [PATCH 0/3] OMAP: Make OMAP LDP boot succussfuly Felipe Balbi
2008-11-10 11:20 ` stanley.miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107155212.GG21860@frodo \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=stanley.miao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.