From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KyWbi-0006EU-LX for mharc-grub-devel@gnu.org; Fri, 07 Nov 2008 14:02:58 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KyWbg-0006CB-QO for grub-devel@gnu.org; Fri, 07 Nov 2008 14:02:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KyWbf-0006AT-Am for grub-devel@gnu.org; Fri, 07 Nov 2008 14:02:56 -0500 Received: from [199.232.76.173] (port=52345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyWbf-0006AL-1t for grub-devel@gnu.org; Fri, 07 Nov 2008 14:02:55 -0500 Received: from mx20.gnu.org ([199.232.41.8]:45766) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KyWbe-0006So-JB for grub-devel@gnu.org; Fri, 07 Nov 2008 14:02:54 -0500 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KyWbd-0001pr-4E for grub-devel@gnu.org; Fri, 07 Nov 2008 14:02:53 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KyWai-0002WP-2I for grub-devel@gnu.org; Fri, 07 Nov 2008 20:01:56 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KyWb4-0002Gg-VF for grub-devel@gnu.org; Fri, 07 Nov 2008 20:02:18 +0100 Date: Fri, 7 Nov 2008 20:02:18 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20081107190218.GA8625@thorin> References: <20081101190204.GB4639@thorin> <49109AB8.4010509@nic.fi> <20081104190751.GA25519@thorin> <49109EE7.6050406@nic.fi> <20081104193911.GA26419@thorin> <491143E2.4040705@t-online.de> <20081105094240.GA12201@thorin> <49121300.2050506@t-online.de> <20081106145252.GA24460@thorin> <49135D60.5080400@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49135D60.5080400@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: __FILE__ (Re: [PATCH] framework for building modules externally) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2008 19:02:57 -0000 On Thu, Nov 06, 2008 at 10:10:56PM +0100, Christian Franke wrote: > > See attached patch for a possible fix: Each module using grub_dprintf > (here disk.c) may specify its name in 'this_file'. When all modules are > changed, the '#define this_file' and all #undefs can be removed. This adds redundancy which later makes it more work to move code around and rename files, etc. Why not make it part of the build system? I.e. to build foo.c, you need gcc -Dfile=foo.c foo.c ? But then again, since gcc is free software perhaps it'd make more sense to add new candy there? (e.g. __RELATIVE_FILE__ or so). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."