From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KyXPV-00020T-Mi for mharc-grub-devel@gnu.org; Fri, 07 Nov 2008 14:54:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KyXPT-000200-TP for grub-devel@gnu.org; Fri, 07 Nov 2008 14:54:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KyXPR-0001wH-Sd for grub-devel@gnu.org; Fri, 07 Nov 2008 14:54:23 -0500 Received: from [199.232.76.173] (port=60036 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyXPR-0001w1-N7 for grub-devel@gnu.org; Fri, 07 Nov 2008 14:54:21 -0500 Received: from aybabtu.com ([69.60.117.155]:58769) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KyXPR-0001dE-Cv for grub-devel@gnu.org; Fri, 07 Nov 2008 14:54:21 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KyXOb-0002fb-F7 for grub-devel@gnu.org; Fri, 07 Nov 2008 20:53:29 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KyXP3-0005Yg-Lq for grub-devel@gnu.org; Fri, 07 Nov 2008 20:53:57 +0100 Date: Fri, 7 Nov 2008 20:53:57 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20081107195357.GG8625@thorin> References: <20081104203627.GA28595@thorin> <200811061823.15421.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200811061823.15421.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Multiboot2 header X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2008 19:54:24 -0000 On Thu, Nov 06, 2008 at 06:23:15PM +0100, Yoshinori K. Okuji wrote: > On Tuesday 04 November 2008 21:36:27 Robert Millan wrote: > > The Multiboot2 draft says a Multiboot2 header must be included in the OS > > image. However, our code assumes (in code itself and in comments) that for > > MB2 this is optional. > > > > As a consequence, if you feed GRUB's multiboot loader any ELF, it will > > attempt to load it. I think this is very confusing for those developing > > a Multiboot _1_ OS. If they happen to make a mistake and put the MB1 > > header too high or unaligned, GRUB won't tell them about it but instead > > fail in a very confusing way. > > > > So I assume (I'd like to!) that the correct one is the draft, and it's the > > code that should be changed to reject executables that don't have either > > MB1 or MB2 headers? > > Yes. The code is wrong. Okay. The fix was fairly simple, I just checked it in. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."