From: Tony Lindgren <tony@atomide.com>
To: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"hyau@mvista.com" <hyau@mvista.com>
Subject: Re: [PATCH] OMAP: LCD: Use omap_rev check
Date: Fri, 7 Nov 2008 11:55:01 -0800 [thread overview]
Message-ID: <20081107195501.GJ21736@atomide.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894413B3903C@dlee02.ent.ti.com>
* Aguirre Rodriguez, Sergio Alberto <saaguirre@ti.com> [081107 08:09]:
> From: Sergio Aguirre <saaguirre@ti.com>
>
> OMAP: LCD: Use omap_rev check
>
> This patch fixes correct detection of OMAP revision for
> LCD driver. This makes Tux look correct on my ES3 SDP board.
Thanks, pushing.
Tony
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> ---
> drivers/video/omap/lcd_2430sdp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-omap-2.6/drivers/video/omap/lcd_2430sdp.c
> ===================================================================
> --- linux-omap-2.6.orig/drivers/video/omap/lcd_2430sdp.c
> +++ linux-omap-2.6/drivers/video/omap/lcd_2430sdp.c
> @@ -88,7 +88,7 @@ static int sdp2430_panel_enable(struct l
> grp_reg = TWL4030_VAUX3_DEV_GRP;
> grp_val = ENABLE_VAUX3_DEV_GRP;
>
> - if (system_rev > OMAP3430_REV_ES1_0) {
> + if (omap_rev() > OMAP3430_REV_ES1_0) {
> t2_out(PM_RECEIVER, ENABLE_VPLL2_DEDICATED,
> TWL4030_VPLL2_DEDICATED);
> t2_out(PM_RECEIVER, ENABLE_VPLL2_DEV_GRP,
> @@ -116,7 +116,7 @@ static void sdp2430_panel_disable(struct
> {
> omap_set_gpio_dataout(enable_gpio, 0);
> omap_set_gpio_dataout(backlight_gpio, 0);
> - if (system_rev > OMAP3430_REV_ES1_0) {
> + if (omap_rev() > OMAP3430_REV_ES1_0) {
> t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEDICATED);
> t2_out(PM_RECEIVER, 0x0, TWL4030_VPLL2_DEV_GRP);
> mdelay(4);
>
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-11-07 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 15:56 [PATCH] OMAP: LCD: Use omap_rev check Aguirre Rodriguez, Sergio Alberto
2008-11-07 19:55 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107195501.GJ21736@atomide.com \
--to=tony@atomide.com \
--cc=hyau@mvista.com \
--cc=linux-omap@vger.kernel.org \
--cc=saaguirre@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.