From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Len Brown <lenb@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Avi Kivity <avi@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again)
Date: Sat, 8 Nov 2008 09:30:08 +0300 [thread overview]
Message-ID: <200811080930.21462.arvidjaar@mail.ru> (raw)
In-Reply-To: <alpine.LFD.2.00.0811072033300.9051@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
On Saturday 08 November 2008, Len Brown wrote:
>
> > > -enum reboot_type reboot_type = BOOT_KBD;
> > > +enum reboot_type reboot_type = BOOT_ACPI;
>
> > NAK.
> >
> > Your point that the set of systems where KBD-reboot is broken is
> > larger (and growing) than the set of systems where ACPI-reboot is
> > broken (which set probably has a constant size) is true.
> >
> > But still this change caused non-trivial regressions in v28 _worse_
> > than the inability to reboot cleanly, so this patch does not fly as-is
> > as we reverted it upstream for a good reason.
>
> If you can direct me to the failures that ACPI reset caused
> in 28, that would be great.
http://marc.info/?l=linux-kernel&m=122547719810921&w=2
> Obviously they are not on
> the linux-acpi archives because the x86 tree enabled
> ACPI reset and then disabled it w/o telling us...
>
> thanks,
> -Len
>
>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-08 6:30 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 4:45 ACPI patchese on test branch Len Brown
2008-11-07 4:45 ` [PATCH 01/10] ACPI: pci_link: remove acpi_irq_balance_set() interface Len Brown
2008-11-07 4:45 ` [PATCH 02/10] ACPI: Disambiguate processor declaration type Len Brown
2008-11-07 4:45 ` [PATCH 03/10] ACPI: Behave uniquely based on processor declaration definition type Len Brown
2008-11-07 4:45 ` [PATCH 04/10] ACPI: 80 column adherence and spelling fix (no functional change) Len Brown
2008-11-07 4:45 ` [PATCH 05/10] Hibernate: Call platform_begin before swsusp_shrink_memory Len Brown
2008-11-07 4:45 ` [PATCH 06/10] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Len Brown
2008-11-07 4:45 ` [PATCH 07/10] x86 hibernate: Mark ACPI NVS memory region at startup Len Brown
2008-11-07 4:45 ` [PATCH 08/10] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs Len Brown
2008-11-07 4:45 ` [PATCH 09/10] compal-laptop: use rfkill switch subsystem Len Brown
2008-11-07 4:45 ` [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again) Len Brown
2008-11-07 7:25 ` Ingo Molnar
2008-11-08 1:41 ` Len Brown
2008-11-08 6:30 ` Andrey Borzenkov [this message]
2008-11-08 7:12 ` Len Brown
2008-11-08 7:50 ` Andrey Borzenkov
2008-11-08 11:59 ` Ingo Molnar
2008-11-09 9:55 ` Avi Kivity
2008-11-09 10:00 ` H. Peter Anvin
2008-11-10 8:39 ` Ingo Molnar
2008-11-10 8:54 ` Avi Kivity
2008-11-10 9:02 ` Ingo Molnar
2008-11-11 18:26 ` H. Peter Anvin
2008-11-11 20:29 ` Eric W. Biederman
2008-11-11 20:44 ` Ingo Molnar
2008-11-10 11:59 ` Matthew Garrett
2008-11-10 11:57 ` Matthew Garrett
2008-11-10 12:56 ` Ingo Molnar
2008-11-10 13:00 ` Matthew Garrett
2008-11-11 23:14 ` Len Brown
2008-11-12 0:25 ` Attempt rebooting via port CF9 if it seems to be available H. Peter Anvin
2008-11-12 18:49 ` Andrey Borzenkov
2008-11-12 0:27 ` [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again) Matthew Garrett
2008-11-12 11:58 ` Ingo Molnar
2008-11-12 12:23 ` Avi Kivity
2008-11-13 3:23 ` Zhao Yakui
2008-11-13 3:18 ` H. Peter Anvin
2008-11-13 3:43 ` Zhao Yakui
2008-11-13 4:10 ` Eric W. Biederman
2008-11-13 4:34 ` H. Peter Anvin
2008-11-13 4:14 ` Eric W. Biederman
2008-11-13 5:29 ` Zhao Yakui
2008-11-13 5:25 ` H. Peter Anvin
2008-11-13 6:56 ` Eric W. Biederman
2008-11-13 6:58 ` Eric W. Biederman
2008-11-13 9:06 ` Zhao Yakui
2008-11-13 17:42 ` H. Peter Anvin
2008-11-14 1:29 ` Zhao Yakui
2008-11-14 1:22 ` H. Peter Anvin
2008-11-14 1:49 ` Zhao Yakui
2008-11-13 3:29 ` Stephen Rothwell
2008-11-08 12:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811080930.21462.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.