From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KytTW-000422-Nh for qemu-devel@nongnu.org; Sat, 08 Nov 2008 14:28:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KytTV-00041Q-Ro for qemu-devel@nongnu.org; Sat, 08 Nov 2008 14:28:02 -0500 Received: from [199.232.76.173] (port=60892 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KytTV-00041L-KG for qemu-devel@nongnu.org; Sat, 08 Nov 2008 14:28:01 -0500 Received: from hall.aurel32.net ([88.191.82.174]:35593) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KytO4-0005Yn-Ct for qemu-devel@nongnu.org; Sat, 08 Nov 2008 14:22:25 -0500 Date: Sat, 8 Nov 2008 20:22:21 +0100 From: Aurelien Jarno Message-ID: <20081108192221.GL15084@volta.aurel32.net> References: <20081108191604.GA20748@volta.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20081108191604.GA20748@volta.aurel32.net> Subject: [Qemu-devel] [PATCH v2 11/11] target-mips: fix temporary variable freeing in op_ldst_##insn() Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Move tcg_temp_free() out of the conditional part to make sure the TCG temporary variable is freed in all cases. Signed-off-by: Aurelien Jarno --- target-mips/translate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 7ec3e2f..0eb95ed 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -1011,13 +1011,13 @@ static inline void op_ldst_##insn(TCGv t0, TCGv t1, DisasContext *ctx) \ gen_set_label(l1); \ tcg_gen_ld_tl(r_tmp, cpu_env, offsetof(CPUState, CP0_LLAddr)); \ tcg_gen_brcond_tl(TCG_COND_NE, t0, r_tmp, l2); \ - tcg_temp_free(r_tmp); \ tcg_gen_qemu_##fname(t1, t0, ctx->mem_idx); \ tcg_gen_movi_tl(t0, 1); \ tcg_gen_br(l3); \ gen_set_label(l2); \ tcg_gen_movi_tl(t0, 0); \ gen_set_label(l3); \ + tcg_temp_free(r_tmp); \ } OP_ST_ATOMIC(sc,st32,0x3); #if defined(TARGET_MIPS64) -- 1.5.6.5 -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net