From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Sun, 09 Nov 2008 15:43:14 +0000 Subject: Re: [PATCH] kvm: ppc: fix Kconfig constraints Message-Id: <20081109154314.GA21374@uranus.ravnborg.org> List-Id: References: <7ef9d93760395985e11f.1226085033@localhost.localdomain> <1226085313.9309.26.camel@localhost.localdomain> <4916B5CE.1080605@redhat.com> In-Reply-To: <4916B5CE.1080605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Avi Kivity Cc: Hollis Blanchard , kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Sun, Nov 09, 2008 at 12:05:02PM +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > >kvm: ppc: fix Kconfig constraints > > > >Make sure that CONFIG_KVM cannot be selected without processor support > >(currently, 440 is the only processor implementation available). > > > >Signed-off-by: Hollis Blanchard > > > >diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > >--- a/arch/powerpc/kvm/Kconfig > >+++ b/arch/powerpc/kvm/Kconfig > >@@ -15,24 +15,22 @@ if VIRTUALIZATION > > if VIRTUALIZATION > > > > config KVM > >- bool "Kernel-based Virtual Machine (KVM) support" > >- depends on EXPERIMENTAL > >+ bool > > select PREEMPT_NOTIFIERS > > select ANON_INODES > >+ > >+config KVM_440 > >+ bool "KVM support for PowerPC 440 processors" > >+ depends on EXPERIMENTAL && 44x > >+ select KVM > > > > I have a vague memory that 'select' will not propagate (what's the word? > transitive?) - -that is, the 'select KVM' will enable KVM but will not > cause ANON_INODES and PREEMPT_NOTIFIERS to be set. I'm glad to say your memory in this case is wrong. Select works recursively so the usage above is OK. If KVM had a dependency such as EXPERIMENTAL then select would enable KVM no matter the value of EXPERIMENTAL. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] kvm: ppc: fix Kconfig constraints Date: Sun, 9 Nov 2008 16:43:14 +0100 Message-ID: <20081109154314.GA21374@uranus.ravnborg.org> References: <7ef9d93760395985e11f.1226085033@localhost.localdomain> <1226085313.9309.26.camel@localhost.localdomain> <4916B5CE.1080605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hollis Blanchard , kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4916B5CE.1080605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On Sun, Nov 09, 2008 at 12:05:02PM +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > >kvm: ppc: fix Kconfig constraints > > > >Make sure that CONFIG_KVM cannot be selected without processor support > >(currently, 440 is the only processor implementation available). > > > >Signed-off-by: Hollis Blanchard > > > >diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > >--- a/arch/powerpc/kvm/Kconfig > >+++ b/arch/powerpc/kvm/Kconfig > >@@ -15,24 +15,22 @@ if VIRTUALIZATION > > if VIRTUALIZATION > > > > config KVM > >- bool "Kernel-based Virtual Machine (KVM) support" > >- depends on EXPERIMENTAL > >+ bool > > select PREEMPT_NOTIFIERS > > select ANON_INODES > >+ > >+config KVM_440 > >+ bool "KVM support for PowerPC 440 processors" > >+ depends on EXPERIMENTAL && 44x > >+ select KVM > > > > I have a vague memory that 'select' will not propagate (what's the word? > transitive?) - -that is, the 'select KVM' will enable KVM but will not > cause ANON_INODES and PREEMPT_NOTIFIERS to be set. I'm glad to say your memory in this case is wrong. Select works recursively so the usage above is OK. If KVM had a dependency such as EXPERIMENTAL then select would enable KVM no matter the value of EXPERIMENTAL. Sam -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html