From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KzIII-0002eI-Hl for mharc-grub-devel@gnu.org; Sun, 09 Nov 2008 16:58:06 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KzIIG-0002e4-Lm for grub-devel@gnu.org; Sun, 09 Nov 2008 16:58:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KzIIE-0002dn-R4 for grub-devel@gnu.org; Sun, 09 Nov 2008 16:58:03 -0500 Received: from [199.232.76.173] (port=54884 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzIIE-0002dk-Kc for grub-devel@gnu.org; Sun, 09 Nov 2008 16:58:02 -0500 Received: from aybabtu.com ([69.60.117.155]:54408) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KzIID-0003Ne-QN for grub-devel@gnu.org; Sun, 09 Nov 2008 16:58:02 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KzIH4-0003JS-Qd for grub-devel@gnu.org; Sun, 09 Nov 2008 22:56:51 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KzIHi-0006s8-R9 for grub-devel@gnu.org; Sun, 09 Nov 2008 22:57:30 +0100 Date: Sun, 9 Nov 2008 22:57:30 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20081109215730.GA26330@thorin> References: <20081106160641.GA26883@thorin> <20081107160725.GD17223@xolotl.n0ano.com> <49147245.6080105@nic.fi> <20081108112536.GA11583@thorin> <491584C4.5020407@nic.fi> <20081108124544.GA25958@thorin> <20081109015819.GA4022@xolotl.n0ano.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081109015819.GA4022@xolotl.n0ano.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] PCI serial card support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Nov 2008 21:58:04 -0000 On Sat, Nov 08, 2008 at 06:58:19PM -0700, n0ano@n0ano.com wrote: > I think this is pretty much what I'm in the middle of doing. I want to > put the infrastructure in place so that we can handle an arbitrary PCI > device but I will only put the actual code in to handle the PCI card that > I have (the only one I can test). > > What I'm doing is creating a table that matches the tuple (vendor id, > device id, subsystem vendor id, subsystem device id, device type, device > type mask) to a base baud and a configuration function. The default > configuration function does nothing so the table only provides the base > baud. We can add config functions for different cards as time goes by. Nice! Aside from base baud and configuration function, I assume we'd also want to specify the I/O port? > Note that what I'm doing will make the serial module dependent upon the > pci module but I don't see that that's a big concern. Pretty much any > modern machine will have a PCI bus so scanning it should not be a > problem. Also, note that the legacy serial devices (I/O ports at > 0x3f8 & 0x2f8) are going away, in the not too distant future the only > way to get serial output will be through PCI or USB. Given that USB > controllers hang off the PCI bus I don't see an issue with having the > serial module require the pci module. If we want to soften the dependency on the pci module, I guess it can always be done afterwards. Vesa, what do you think? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."