From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: x86_32 has its own irq_regs definition
Date: Mon, 10 Nov 2008 08:42:01 +0100 [thread overview]
Message-ID: <20081110074201.GA2093@elte.hu> (raw)
In-Reply-To: <1226294895.5478.5.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Impact: prevent second percpu define of unused irq_regs
>
> Arches that have their own irq_regs definition are expected to
> define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set
> will also be defined in lib/irq_regs.c
>
> Sparse noticed the unused generic one had no prototype:
> lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/include/asm/irq_regs_32.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
applied to tip/x86/cleanups, thanks Harvey!
Ingo
prev parent reply other threads:[~2008-11-10 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 5:28 [PATCH] x86: x86_32 has its own irq_regs definition Harvey Harrison
2008-11-10 7:42 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110074201.GA2093@elte.hu \
--to=mingo@elte.hu \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.