From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OneNAND: Fix compiler warnings and add weak attribute to memcpy_16()
Date: Mon, 10 Nov 2008 17:46:51 +0100 [thread overview]
Message-ID: <200811101746.51575.sr@denx.de> (raw)
In-Reply-To: <49186108.7040901@freescale.com>
On Monday 10 November 2008, Scott Wood wrote:
> >> Can it just override write_bufferram and read_bufferram?
> >
> > There are multiple functions here using this memcpy_16():
> >
> > onenand_read_bufferram()
> > onenand_sync_read_bufferram()
> > onenand_write_bufferram()
> >
> > So it seemed "easier" for me to just override the memcpy_16() function
> > itself.
>
> onenand_read_bufferram and onenand_sync_read_bufferram are alternatives
> for the read_bufferram method; you don't need to provide both. Thus,
> it's two method overrides versus two weak overrides. Unless the board
> code doesn't know which of the two types of read will be used?
Yes, you're right of course. I'll give it a try and send an updated patch (if
needed) soon.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2008-11-10 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 15:09 [U-Boot] [PATCH] OneNAND: Fix compiler warnings and add weak attribute to memcpy_16() Stefan Roese
2008-11-07 22:25 ` Scott Wood
2008-11-08 5:36 ` Stefan Roese
2008-11-10 16:27 ` Scott Wood
2008-11-10 16:46 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811101746.51575.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.