All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Christian Pellegrin <chripell@gmail.com>,
	alsa-devel@alsa-project.org,
	Christian Pellegrin <chripell@fsfe.org>,
	linux-arm-kernel@lists.arm.linux.org.uk, zdevai@gmail.com
Subject: Re: [alsa-devel] [PATCH] ALSA SOC driver for s3c24xx with uda1341
Date: Mon, 10 Nov 2008 19:22:46 +0000	[thread overview]
Message-ID: <20081110192246.GG30417@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20081110133451.GD12804@sirena.org.uk>

On Mon, Nov 10, 2008 at 01:34:52PM +0000, Mark Brown wrote:
> > +	xtal = clk_get(NULL, "xtal");
> > +	pclk = clk_get(NULL, "pclk");
> 
> This should be done in the init function for the device and should
> really check the return value in case it can't get the clock for some
> reason.  Ideally there'd be a dev there, but I'd need to check if the
> s3c24xx stuff does that.

And should not be passing a NULL device to clk_get().

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

  parent reply	other threads:[~2008-11-10 19:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  7:43 [PATCH] ALSA SOC driver for s3c24xx with uda1341 Christian Pellegrin
2008-11-10 13:34 ` Mark Brown
2008-11-10 17:58   ` Kristoffer Ericson
2008-11-10 19:08     ` chri
2008-11-10 20:22       ` Kristoffer Ericson
2008-11-10 22:10         ` [alsa-devel] " Ben Dooks
2008-11-11 14:15           ` chri
2008-11-11 18:55             ` Kristoffer Ericson
2008-11-11 20:53             ` Kristoffer Ericson
2008-11-12  6:31               ` christian pellegrin
2008-11-10 19:04   ` chri
2008-11-11 10:39     ` Mark Brown
2008-11-11 14:16       ` chri
2008-11-10 19:22   ` Russell King - ARM Linux [this message]
2008-11-11 14:00     ` chri
2008-11-10 22:09 ` Ben Dooks
2008-11-11 14:14   ` chri
2008-11-11 15:52     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081110192246.GG30417@flint.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    --cc=chripell@fsfe.org \
    --cc=chripell@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=zdevai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.