From: akpm@linux-foundation.org
To: darrenrjenkins@gmail.com, hirofumi@mail.parknet.co.jp,
mm-commits@vger.kernel.org
Subject: - fat-cleanup-fat_parse_long-error-handling.patch removed from -mm tree
Date: Mon, 10 Nov 2008 12:33:17 -0800 [thread overview]
Message-ID: <200811102033.mAAKXHaP024402@imap1.linux-foundation.org> (raw)
The patch titled
fat: cleanup fat_parse_long() error handling
has been removed from the -mm tree. Its filename was
fat-cleanup-fat_parse_long-error-handling.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: fat: cleanup fat_parse_long() error handling
From: "Darren Jenkins" <darrenrjenkins@gmail.com>
Coverity CID 2332 & 2333 RESOURCE_LEAK
In fat_search_long() if fat_parse_long() returns a -ve value we return
without first freeing unicode. This patch free's them on this error path.
The above was false positive on current tree, but this change is more
clean, so apply as cleanup.
[hirofumi@mail.parknet.co.jp: fix coding style]
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/fat/dir.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff -puN fs/fat/dir.c~fat-cleanup-fat_parse_long-error-handling fs/fat/dir.c
--- a/fs/fat/dir.c~fat-cleanup-fat_parse_long-error-handling
+++ a/fs/fat/dir.c
@@ -373,9 +373,10 @@ parse_record:
if (de->attr == ATTR_EXT) {
int status = fat_parse_long(inode, &cpos, &bh, &de,
&unicode, &nr_slots);
- if (status < 0)
- return status;
- else if (status == PARSE_INVALID)
+ if (status < 0) {
+ err = status;
+ goto end_of_dir;
+ } else if (status == PARSE_INVALID)
continue;
else if (status == PARSE_NOT_LONGNAME)
goto parse_record;
_
Patches currently in -mm which might be from darrenrjenkins@gmail.com are
reply other threads:[~2008-11-10 20:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811102033.mAAKXHaP024402@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=darrenrjenkins@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.