From: Michael Buesch <mb@bu3sch.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: ssb: Fix DMA-API compilation for non-PCI systems
Date: Mon, 10 Nov 2008 23:07:37 +0100 [thread overview]
Message-ID: <200811102307.37838.mb@bu3sch.de> (raw)
In-Reply-To: <20081110.135231.96349017.davem@davemloft.net>
On Monday 10 November 2008 22:52:31 David Miller wrote:
>
> I applied this since it's a build buster and we should
> get it fixed quickly.
>
> But as I look at this, the thing to really do here is get
> rid of these stupid switch statements. None of it is needed.
>
> The layer that sets up the SSB devices should simply save the
> generic device pointer for the DMA entity into some new
> ->dma_dev struct member.
>
> Then you just use generic dma_*() interfaces unilaterally. For PCI
> devices it will "just work".
We tried that. It doesn't work. It breaks on several architectures
that do special things in the pci_dma... functions.
See the git history and mailinglists, please.
--
Greetings Michael.
next prev parent reply other threads:[~2008-11-10 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 21:52 ssb: Fix DMA-API compilation for non-PCI systems David Miller
2008-11-10 22:07 ` Michael Buesch [this message]
2008-11-10 22:53 ` David Miller
2008-11-10 23:32 ` Michael Buesch
2008-11-11 8:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811102307.37838.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.