From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Dave Airlie" <airlied@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Dave Airlie" <airlied@linux.ie>,
torvalds@linux-foundation.org, dri-devel@lists.sf.net,
linux-kernel@vger.kernel.org
Subject: Re: [git pull] drm fixes for 2.6.27-rc5
Date: Tue, 11 Nov 2008 10:13:34 -0800 [thread overview]
Message-ID: <200811111013.35358.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <21d7e9970811110037l49e7b28bl2480863682cda0c@mail.gmail.com>
On Tuesday, November 11, 2008 12:37 am Dave Airlie wrote:
> On Tue, Nov 11, 2008 at 6:29 PM, Andrew Morton
>
> <akpm@linux-foundation.org> wrote:
> > On Tue, 11 Nov 2008 08:15:26 +0000 (GMT) Dave Airlie <airlied@linux.ie>
wrote:
> >> commit 78538bf14995a136c2d9a22159ada49937359119
> >> Author: Dave Airlie <airlied@linux.ie>
> >> Date: Tue Nov 11 17:56:16 2008 +1000
> >>
> >> drm/radeon: map registers at load time
> >>
> >> Now that the radeon driver has suspend/resume functions, it needs to
> >> map its registers at load time or it will likely crash if a suspend
> >> operation occurs before the driver has been initialized.
> >>
> >> This patch moves the register mapping code from firstopen to load
> >> and makes the mapping into a _DRM_DRIVER one so that the core won't
> >> remove it at lastclose time.
> >
> > Does this make the below patch obsolete?
>
> Yes please drop this, the correct fix is the one Jesse posted + a fix
> on top of it I made in the same patch.
Oh geez, yeah that's ugly, thanks for catching it.
Jesse
prev parent reply other threads:[~2008-11-11 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 8:15 [git pull] drm fixes for 2.6.27-rc5 Dave Airlie
2008-11-11 8:29 ` Andrew Morton
2008-11-11 8:37 ` Dave Airlie
2008-11-11 18:13 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811111013.35358.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.sf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.