All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] OneNAND: Continuous locking scheme?
Date: Tue, 11 Nov 2008 10:16:06 +0100	[thread overview]
Message-ID: <200811111016.07132.sr@denx.de> (raw)
In-Reply-To: <9c9fda240811110104v758544d6y72547a302d567c99@mail.gmail.com>

On Tuesday 11 November 2008, Kyungmin Park wrote:
> > I'm still new to OneNAND and I couldn't
> > find any reference to this continuous locking scheme in the OneNAND chip
> > used here. Do you have any idea why this is not working for us? Do you
> > know for sure if the KFG1216U2B (Dev-ID 0x25) really supports this
> > continuous locking scheme?
>
> In onenand_check_features()
>
>           default:
>                 /* Some OneNAND has continuous lock scheme */
>                 if (!process)
>                         this->options |= ONENAND_HAS_CONT_LOCK;
>
> It's some strange. As your version id is 0x22e. then process is 0x2.
> umm maybe options field is not cleared before. please check this one.

No, that's not the problem. The problem is that version_id was never saved in 
the onenand_chip structure. This is missing:

@@ -1972,6 +1972,7 @@ static int onenand_probe(struct mtd_info *mtd)
        /* Flash device information */
        mtd->name = onenand_print_device_info(dev_id, ver_id);
        this->device_id = dev_id;
+       this->version_id = ver_id;

I'll submit a patch in a short while to fix this.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2008-11-11  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11  8:43 [U-Boot] OneNAND: Continuous locking scheme? Stefan Roese
2008-11-11  9:04 ` Kyungmin Park
2008-11-11  9:16   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811111016.07132.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.