From: Ingo Molnar <mingo@elte.hu>
To: Ivan Vecera <ivecera@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, nhorman@redhat.com,
jmarchan@redhat.com, pavel@suse.cz
Subject: Re: [PATCH] x86: call machine_shutdown and stop all CPUs in native_machine_halt
Date: Tue, 11 Nov 2008 14:47:06 +0100 [thread overview]
Message-ID: <20081111134701.GA28900@elte.hu> (raw)
In-Reply-To: <49197ED9.6090906@redhat.com>
* Ivan Vecera <ivecera@redhat.com> wrote:
> Ingo Molnar wrote:
> > looks good. One small detail:
> >
> >> +#ifdef CONFIG_X86_LOCAL_APIC
> >> + disable_local_APIC();
> >> +#endif
> >
> > could you please avoid this #ifdef by putting an inline void function
> > for disable_local_APIC() into arch/x86/include/asm/apic.h for the
> > !CONFIG_X86_LOCAL_APIC case?
> >
> > Ingo
> OK, here is the result.
>
> Ivan
>
> ---
> arch/x86/include/asm/apic.h | 1 +
> arch/x86/include/asm/system.h | 2 ++
> arch/x86/kernel/process.c | 14 ++++++++++++++
> arch/x86/kernel/reboot.c | 5 +++++
> arch/x86/kernel/smp.c | 13 -------------
> 5 files changed, 22 insertions(+), 13 deletions(-)
applied to tip/x86/reboot, thanks Ivan!
Ingo
prev parent reply other threads:[~2008-11-11 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 12:13 [PATCH] x86: call machine_shutdown and stop all CPUs in native_machine_halt Ivan Vecera
2008-10-20 14:39 ` Neil Horman
2008-10-20 16:00 ` Ingo Molnar
2008-10-21 12:36 ` Ivan Vecera
2008-11-06 16:10 ` Ivan Vecera
2008-11-06 16:15 ` Neil Horman
2008-11-10 22:49 ` Pavel Machek
2008-11-11 12:48 ` Ivan Vecera
2008-11-06 20:43 ` Ingo Molnar
2008-11-11 12:47 ` Ivan Vecera
2008-11-11 13:47 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111134701.GA28900@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=ivecera@redhat.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=pavel@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.