From: Andrew Morton <akpm@linux-foundation.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: a.zummo@towertech.it, david-b@pacbell.net,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing
Date: Tue, 11 Nov 2008 16:17:28 -0800 [thread overview]
Message-ID: <20081111161728.8a0d73f1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081106174111.GA21882@oksana.dev.rtsoft.ru>
On Thu, 6 Nov 2008 20:41:11 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> This patch fixes bunch of irq checking misuses. Most drivers were getting
> irq via platform_get_irq(), which returns -ENXIO or r->start. Platforms
> may specify r->start = 0 to emphasize 'no irq' case, and drivers should
> handle this correctly.
>
> rtc-cmos.c is special. It is using PNP and platform bindings. Hopefully
> nobody is using PNP IRQ 0 for RTC. So the changes should be safe.
>
> rtc-sh.c is using platform_get_irq, but was storing a result into an
> unsigned type, then was checking for < 0. This is fixed now.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Do we see any reason why this should be pushed into 2.6.28?
next prev parent reply other threads:[~2008-11-12 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 17:41 [PATCH] rtc: bunch of drivers: fix 'no irq' case handing Anton Vorontsov
2008-11-10 22:34 ` David Brownell
2008-11-12 0:17 ` Andrew Morton [this message]
2008-11-12 10:21 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111161728.8a0d73f1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=avorontsov@ru.mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.