Re: [rft/rfc/patch-2.6.28-rc3+ 00/59] namespace cleanup patches

[Felipe Balbi <me@felipebalbi.com>]

On Tue, Nov 11, 2008 at 03:47:13PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <me@felipebalbi.com> [081111 15:22]:
> > On Wed, Nov 12, 2008 at 12:56:19AM +0200, Felipe Balbi wrote:
> > > From: Felipe Balbi <felipe.balbi@nokia.com>
> > > 
> > > Get rid of omap_{read,write}[bsl] defines.
> > > Virtual and physical addresses usage was fixed by Russel King and
> > > there's no need anymore for keeping a define to a standard kernel
> > > function. Get rid of those to keep the namespace cleaner.
> > > 
> > > Build tested with all omap defconfigs.
> > > Depends on my previous "make clk fwk build again on omap1" patch.
> > 
> > for convinience, these patches plus the clock fix for omap1 and the mmc
> > fix are available at [1]
> 
> Felipe, have you tested any of these? To me looks like you're missing
> the associated ioremap before you can use __raw_read/write instead of
> omap_read/write.

You're right, I should at least use __raw_read/write(IO_ADDRESS(...));

I'll fix it by tomorrow and test on omap3.

-- 
balbi