From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 1/2] ring-buffer: fix deadlock from reader_lock in read_start
Date: Wed, 12 Nov 2008 11:25:18 +0100 [thread overview]
Message-ID: <20081112102518.GC24482@elte.hu> (raw)
In-Reply-To: <20081112050218.952245378@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Impact: deadlock fix in ring_buffer_read_start
>
> The ring_buffer_iter_reset was called from ring_buffer_read_start
> where both grabbed the reader_lock.
>
> This patch separates out the internals of ring_buffer_iter_reset
> to its own function so that both APIs may grab the reader_lock.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> ---
> kernel/trace/ring_buffer.c | 29 +++++++++++++++++------------
> 1 files changed, 17 insertions(+), 12 deletions(-)
applied to tip/tracing/ring-buffer, thanks Steve!
Ingo
next prev parent reply other threads:[~2008-11-12 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 5:01 [PATCH 0/2] ring-buffer updates for tip Steven Rostedt
2008-11-12 5:01 ` [PATCH 1/2] ring-buffer: fix deadlock from reader_lock in read_start Steven Rostedt
2008-11-12 10:25 ` Ingo Molnar [this message]
2008-11-12 5:01 ` [PATCH 2/2] ring-buffer: no preempt for sched_clock Steven Rostedt
2008-11-12 10:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112102518.GC24482@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.