From: Christoph Hellwig <hch@lst.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5627] Add KVM support to QEMU
Date: Wed, 12 Nov 2008 11:42:15 +0100 [thread overview]
Message-ID: <20081112104215.GA11733@lst.de> (raw)
In-Reply-To: <E1Kxkrx-0006Lk-OG@cvs.savannah.gnu.org>
On Wed, Nov 05, 2008 at 04:04:33PM +0000, Anthony Liguori wrote:
> +# kvm probe
> +if test "$kvm" = "yes" ; then
> + cat > $TMPC <<EOF
> +#include <linux/kvm.h>
> +#if !defined(KVM_API_VERSION) || \
> + KVM_API_VERSION < 12 || \
> + KVM_API_VERSION > 12 || \
> + !defined(KVM_CAP_USER_MEMORY) || \
> + !defined(KVM_CAP_SET_TSS_ADDR)
> +#error Invalid KVM version
> +#endif
The installed linux/kvm.h has no relatation at all to the currently
running kernel. Please ship a current max API version kvm.h with qemu
and always build against that one, and handle lower API versions at
runtime. Please don't turn mainline qemu kvm support into the same
bloody mess as the kvm userspace repository.
next prev parent reply other threads:[~2008-11-12 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 16:04 [Qemu-devel] [5627] Add KVM support to QEMU Anthony Liguori
2008-11-05 16:19 ` andrzej zaborowski
2008-11-05 16:30 ` Anthony Liguori
2008-11-05 18:34 ` [Qemu-devel] " Jan Kiszka
2008-11-12 10:42 ` Christoph Hellwig [this message]
2008-11-13 19:56 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112104215.GA11733@lst.de \
--to=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.