From: Ingo Molnar <mingo@elte.hu>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Vaidyanathan S <svaidyan@in.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
efault@gmx.de
Subject: Re: [PATCH][mmotm] Sched fix stale value in average load per task
Date: Wed, 12 Nov 2008 12:46:14 +0100 [thread overview]
Message-ID: <20081112114614.GA11352@elte.hu> (raw)
In-Reply-To: <20081112113852.GA26884@balbir.in.ibm.com>
* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * Balbir Singh <balbir@linux.vnet.ibm.com> [2008-11-12 16:19:00]:
>
> > + else
> > + rq->avg_load_per_task = 0;
> >
> > return rq->avg_load_per_task;
>
> On second thoughts, does this look better? (Based on Mike
> Galbraith's suggestion)
yes - but could you send it as a delta patch against your previous
patch please? We want the simpler patch for tip/sched/urgent, as a
v2.6.28 fix - the removal of rq->avg_load_per_task can wait until
v2.6.29. (Please also include Mike's Ack in the patch if he acks the
patch.)
Ingo
next prev parent reply other threads:[~2008-11-12 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 10:49 [PATCH][mmotm] Sched fix stale value in average load per task Balbir Singh
2008-11-12 11:35 ` Ingo Molnar
2008-11-12 11:52 ` Balbir Singh
2008-11-12 11:38 ` Balbir Singh
2008-11-12 11:46 ` Ingo Molnar [this message]
2008-11-12 11:53 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112114614.GA11352@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=bharata@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=svaidyan@in.ibm.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.