From: Arnd Bergmann <arnd@arndb.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org,
Holger Waechtler <holger@convergence.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ttusb-budget: make it depend on PCI
Date: Wed, 12 Nov 2008 14:46:59 +0100 [thread overview]
Message-ID: <200811121447.00808.arnd@arndb.de> (raw)
In-Reply-To: <874p2ddr72.fsf@basil.nowhere.org>
On Wednesday 12 November 2008, Andi Kleen wrote:
> Unless it really needs to use the 16MB DMA zone (which I doubt
> especially for USB devices) then it should not call either with a NULL
> device argument.
Yes, of course. It will need to pass &ttusb->dev.dev to dma_alloc_coherent.
Arnd <><
---
Note to self: read code before commenting on it...
next prev parent reply other threads:[~2008-11-12 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 12:00 [PATCH] ttusb-budget: make it depend on PCI Mike Frysinger
2008-11-12 12:04 ` [PATCH] ttusb-dec: " Mike Frysinger
2008-11-12 12:35 ` [PATCH] ttusb-budget: " Arnd Bergmann
2008-11-12 13:11 ` Andi Kleen
2008-11-12 13:46 ` Arnd Bergmann [this message]
2008-11-12 13:17 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811121447.00808.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andi@firstfloor.org \
--cc=holger@convergence.de \
--cc=linux-dvb@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.