From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Wed, 12 Nov 2008 20:45:51 +0100 Subject: [U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch instead of common In-Reply-To: <1aad82fa0811121136t3e33762co5567d173e3172c2c@mail.gmail.com> References: <20081112145756.GB7014@game.jcrosoft.org> <1226517200-30196-1-git-send-email-plagnioj@jcrosoft.com> <1aad82fa0811121136t3e33762co5567d173e3172c2c@mail.gmail.com> Message-ID: <20081112194551.GA9862@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 14:36 Wed 12 Nov , Mike Frysinger wrote: > On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and > > soc to print more information > > there seems to be things that all arches print ... like memory and > flash information. perhaps that should be left in the common > bdinfo(). I've prefered to let arch print this how they wish > > +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) > > + if(soc_bdinfo) > > + if(board_bdinfo) > > you've got random whitespace damage all over this patch ... I known, but I not suposed to fix PPC whitespace in the patch I've an other one when everyone will agree on this one Best Regards, J.