From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [DLM] Fix up memory alloc/kmap
Date: Wed, 12 Nov 2008 17:14:10 -0600 [thread overview]
Message-ID: <20081112231410.GF29551@redhat.com> (raw)
In-Reply-To: <1226401377.9571.2.camel@quoit>
On Tue, Nov 11, 2008 at 11:02:57AM +0000, Steven Whitehouse wrote:
> In addition kmap was being used incorrectly. The reason that this hasn't
> been seen before is that the pages are allocated using ls->ls_allocation
> which doesn't allow highmem pages to be returned. I haven't changed that
> since although kmap implies a GFP_KERNEL allocation, without highmem
> pages, they will be no-ops for now and thus safe. Also sendpage does its
> own kmap (if required, which is only if the protocol is emulating
> sendpage via sock_no_sendpage) so that the k(un)map pair around that
> call can be removed.
Sorry, I don't understand this, it's late and I'm probably being dense...
- We can remove kmap/kunmap from send_to_sock() because...
- We can remove kmap/kunmap from sctp_init_assoc() because...
- We cannot remove kmap/kunmap from dlm_lowcomms_get_buffer/
dlm_lowcomms_commit_buffer because...
next prev parent reply other threads:[~2008-11-12 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 15:05 [Cluster-devel] [DLM] Fix up memory alloc/kmap Steven Whitehouse
2008-11-11 11:02 ` Steven Whitehouse
2008-11-12 23:14 ` David Teigland [this message]
2008-11-13 9:56 ` [Cluster-devel] " Steven Whitehouse
2008-11-13 17:29 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112231410.GF29551@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.