From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] SPI lm70: Code streamlining and cleanup
Date: Thu, 13 Nov 2008 09:34:53 +0000 [thread overview]
Message-ID: <20081113103453.215df73c@hyperion.delvare> (raw)
In-Reply-To: <1226474799.18411.21.camel@kaiwan-1>
Hi Kaiwan,
On Thu, 13 Nov 2008 10:53:58 +0530, Kaiwan N Billimoria wrote:
> On Wed, 2008-11-12 at 14:25 +0100, Jean Delvare wrote:
> > > --- a/Documentation/spi/spi-lm70llp 2008-10-10 03:43:53.000000000 +0530
> > > +++ b/Documentation/spi/spi-lm70llp 2008-11-12 12:13:50.000000000 +0530
> > > @@ -13,10 +13,19 @@ Description
> > > This driver provides glue code connecting a National Semiconductor LM70 LLP
> > > temperature sensor evaluation board to the kernel's SPI core subsystem.
> > >
> > > +This is an SPI master controller driver. It can be used in conjunction with
> > > +(layered under) the LM70 logical driver (an "SPI protocol driver").
> > > In effect, this driver turns the parallel port interface on the eval board
> > > into a SPI bus with a single device, which will be driven by the generic
> > > LM70 driver (drivers/hwmon/lm70.c).
> > >
> > > +
> > > +Hardware Interfacing
> > > +--------------------
> > > +The schematic for this particular board (the LM70LLP eval board) is
> > > +available (on page 4) here:
> > > +http://www.designergraphix.com/pull/spi_lm70/LM70LLPEVALmanual.pdf
> > > +
> > > The hardware interfacing on the LM70 LLP eval board is as follows:
> > >
> > > Parallel LM70 LLP
> > > @@ -67,3 +76,4 @@ Thanks to
> > > o David Brownell for mentoring the SPI-side driver development.
> > > o Dr.Craig Hollabaugh for the (early) "manual" bitbanging driver version.
> > > o Nadir Billimoria for help interpreting the circuit schematic.
> > > +
> >
> > Pointless change, should be reverted.
>
> Sorry I do not follow you..which part are you referring to as pointless?
> IMHO, the schematic PDF download is important for anyone trying to
> understand the 'physical' driver.
The change I was referring to is: adding a blank line at the end of the
file. I have no objection to the other ("real") changes!
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-11-13 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 7:38 [lm-sensors] [PATCH] SPI lm70: Code streamlining and cleanup Kaiwan N Billimoria
2008-11-12 7:59 ` David Brownell
2008-11-12 8:30 ` Kaiwan N Billimoria
2008-11-12 13:25 ` Jean Delvare
2008-11-13 5:35 ` Kaiwan N Billimoria
2008-11-13 8:53 ` David Brownell
2008-11-13 9:34 ` Jean Delvare [this message]
2008-11-13 9:55 ` Jean Delvare
2008-11-13 11:52 ` Kaiwan N Billimoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113103453.215df73c@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.