From: Andres Salomon <dilinger@queued.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Pavel Machek <pavel@suse.cz>, Jeremy Katz <katzj@redhat.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Jordan Crouse <jordan.crouse@amd.com>,
linux-kernel@vger.kernel.org, dsaxena@laptop.org
Subject: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined
Date: Thu, 13 Nov 2008 11:14:28 -0500 [thread overview]
Message-ID: <20081113111428.59aa36cb@ephemeral> (raw)
In-Reply-To: <s5h3ahvhb9w.wl%tiwai@suse.de>
On Thu, 13 Nov 2008 16:54:19 +0100
Takashi Iwai <tiwai@suse.de> wrote:
> At Thu, 13 Nov 2008 16:37:14 +0100,
> Pavel Machek wrote:
[...]
> >
> > > IMO, the basic problem is rather that the platform and the CPU
> > > selection is mixed up. The geode GPIO stuff shouldn't belong to
> > > CPU selection.
> >
> > ACK... and suggested patch makes it worse.
> >
> > There should be option 'support OLPC' somewhere, and that should
> > enable the gpio bits. Alsa driver should depend on that one.
>
> Any better fix patch is welcome, of course :)
> This would make save a lot time than writing mails...
>
>
> thanks,
>
> Takashi
Okay, how about something like the following?
This is a temporary work-around until the geode_gpio* calls are moved out
into a separate config option. We don't want to force generic kernel
maintainers to have to build a specific OLPC kernel.
Signed-off-by: Andres Salomon <dilinger@debian.org>
---
sound/pci/cs5535audio/Makefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/pci/cs5535audio/Makefile b/sound/pci/cs5535audio/Makefile
index ccc6422..fda7a94 100644
--- a/sound/pci/cs5535audio/Makefile
+++ b/sound/pci/cs5535audio/Makefile
@@ -4,7 +4,9 @@
snd-cs5535audio-y := cs5535audio.o cs5535audio_pcm.o
snd-cs5535audio-$(CONFIG_PM) += cs5535audio_pm.o
+ifdef CONFIG_MGEODE_LX
snd-cs5535audio-$(CONFIG_OLPC) += cs5535audio_olpc.o
+endif
# Toplevel Module Dependency
obj-$(CONFIG_SND_CS5535AUDIO) += snd-cs5535audio.o
--
1.5.6.5
next prev parent reply other threads:[~2008-11-13 16:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 12:23 [PATCH] x86 - Make CONFIG_OLPC dependent on CONFIG_MGEODE_LX Takashi Iwai
2008-11-11 12:54 ` Ingo Molnar
2008-11-11 13:45 ` Takashi Iwai
2008-11-11 13:53 ` Ingo Molnar
2008-11-11 13:58 ` Takashi Iwai
2008-11-11 14:04 ` Ingo Molnar
2008-11-10 4:17 ` Andres Salomon
2008-11-12 10:53 ` Takashi Iwai
2008-11-12 17:04 ` Andres Salomon
2008-11-12 13:54 ` Jeremy Katz
2008-11-12 14:29 ` Takashi Iwai
2008-11-13 3:44 ` Jeremy Katz
2008-11-13 6:54 ` Takashi Iwai
2008-11-13 15:37 ` Pavel Machek
2008-11-13 15:54 ` Takashi Iwai
2008-11-13 16:14 ` Andres Salomon [this message]
2008-11-13 16:31 ` [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined Takashi Iwai
2008-11-13 17:12 ` Takashi Iwai
2008-11-13 16:38 ` Pavel Machek
2008-11-13 16:42 ` Takashi Iwai
2008-11-13 17:01 ` Andres Salomon
2008-11-13 19:03 ` Ingo Molnar
2008-11-13 23:30 ` Takashi Iwai
2008-11-14 2:38 ` Andres Salomon
2008-11-14 6:54 ` Takashi Iwai
2008-11-14 7:52 ` Pavel Machek
2008-11-14 17:34 ` Jordan Crouse
2008-11-14 18:45 ` Jeremy Katz
2008-11-14 19:24 ` Jordan Crouse
2008-11-14 21:10 ` Andres Salomon
2008-12-10 16:49 ` Takashi Iwai
2008-12-10 18:41 ` Andres Salomon
2008-12-11 7:08 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113111428.59aa36cb@ephemeral \
--to=dilinger@queued.net \
--cc=dsaxena@laptop.org \
--cc=jordan.crouse@amd.com \
--cc=katzj@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.