From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-kernel@vger.kernel.org,
Felipe Balbi <felipe.balbi@nokia.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>, Greg KH <greg@kroah.com>,
Pierre Ossman <drzeus@drzeus.cx>,
Richard Purdie <rpurdie@linux.intel.com>
Subject: Re: [PATCH] led: simplify led_trigger_register_simple
Date: Thu, 13 Nov 2008 15:03:12 +0300 [thread overview]
Message-ID: <20081113120312.GA30307@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1226545753-6640-1-git-send-email-me@felipebalbi.com>
On Thu, Nov 13, 2008 at 05:09:13AM +0200, Felipe Balbi wrote:
> From: Felipe Balbi <felipe.balbi@nokia.com>
>
> We can make led_trigger_register_simple by returning a
> struct led_trigger *, instead of passing a struct led_trigger **
> as a parameter and changing it inside the function.
>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Greg KH <greg@kroah.com>
> Cc: Pierre Ossman <drzeus@drzeus.cx>
> Cc: Richard Purdie <rpurdie@linux.intel.com>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> Note that I could only test ide, power_supply and mmc changes with my laptop.
> The other changes weren't tested.
>
> drivers/leds/led-triggers.c | 25 ++++++++++++++---------
> drivers/leds/ledtrig-ide-disk.c | 6 ++++-
> drivers/mmc/core/host.c | 4 ++-
> drivers/mtd/nand/nand_base.c | 5 +++-
> drivers/power/power_supply_leds.c | 36 ++++++++++++++++++++++++++++------
For power supply bits:
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Thanks.
next prev parent reply other threads:[~2008-11-13 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 3:09 [PATCH] led: simplify led_trigger_register_simple Felipe Balbi
2008-11-13 12:03 ` Anton Vorontsov [this message]
2008-11-13 12:38 ` Richard Purdie
2008-11-13 18:14 ` Felipe Balbi
2008-11-13 19:10 ` Felipe Balbi
2008-11-20 13:10 ` Felipe Balbi
2008-11-20 13:33 ` Richard Purdie
2008-11-20 14:14 ` Felipe Balbi
2008-11-20 14:45 ` Richard Purdie
2008-11-20 15:01 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113120312.GA30307@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=cbou@mail.ru \
--cc=drzeus@drzeus.cx \
--cc=dwmw2@infradead.org \
--cc=felipe.balbi@nokia.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.