From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH] omap1: clk: make clk fwk build again on omap1 Date: Thu, 13 Nov 2008 21:12:35 +0200 Message-ID: <20081113191234.GB25855@frodo> References: <1226444207-14588-1-git-send-email-me@felipebalbi.com> <20081113185548.GA3106@atomide.com> <20081113185740.GA17468@frodo> <20081113190241.GB3106@atomide.com> Reply-To: me@felipebalbi.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns1.siteground211.com ([209.62.36.12]:55254 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbYKMTMo (ORCPT ); Thu, 13 Nov 2008 14:12:44 -0500 Content-Disposition: inline In-Reply-To: <20081113190241.GB3106@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Felipe Balbi , linux-omap@vger.kernel.org, Felipe Balbi , Paul Walmsley On Thu, Nov 13, 2008 at 11:02:42AM -0800, Tony Lindgren wrote: > * Felipe Balbi [081113 11:00]: > > On Thu, Nov 13, 2008 at 10:55:49AM -0800, Tony Lindgren wrote: > > > * Felipe Balbi [081111 14:57]: > > > > From: Felipe Balbi > > > > > > > > Fix it by passing u32 into enable_reg and letting > > > > clock.c use OMAP1_IO_ADDRESS(). > > > > > > > > This will probably be changed by a better solution > > > > later on, but at least we make it buildable again. > > > > > > Huh? At least OSK builds and boots just fine here. > > > Have you tested this patch? > > > > It builds with or without this patch ? > > Builds and boots without this patch. Funny, I got broken compilation on all omap1 defconfigs, that's why I put down this patch. My toolchain could be broken, maybe ? Gotta check that. -- balbi