From: Andi Kleen <andi@firstfloor.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Andi Kleen <andi@firstfloor.org>, Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: don't grab devices with no input
Date: Thu, 13 Nov 2008 23:22:00 +0100 [thread overview]
Message-ID: <20081113222200.GD3810@one.firstfloor.org> (raw)
In-Reply-To: <491CA495.7010007@gmail.com>
On Thu, Nov 13, 2008 at 11:05:09PM +0100, Jiri Slaby wrote:
> On 11/13/2008 10:37 PM, Alan Stern wrote:
> >> + for (n = 0; n < interface->desc.bNumEndpoints; n++)
> >> + if (usb_endpoint_dir_in(&interface->endpoint[n].desc))
> >> + has_in++;
> >> + if (!has_in) {
> >> + dev_err(&intf->dev, "couldn't find an input interrupt "
> >> + "endpoint");
> >> + return -ENODEV;
> >> + }
> >> +
> >
> > Do you want to use usb_endpoint_is_int_in() instead? It matches the
> > error message more closely.
>
> Yes, good catch, thanks.
Should I test it with that change or the original version?
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-13 22:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 0:31 USB hid blocks USB port in 2.6.28rc3 Andi Kleen
2008-11-11 0:45 ` Alan Stern
2008-11-11 8:41 ` Andi Kleen
2008-11-11 17:02 ` Alan Stern
2008-11-11 21:07 ` Andi Kleen
[not found] ` <20081111210705.GG3810-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2008-11-12 14:53 ` Alan Stern
2008-11-15 23:58 ` Rafael J. Wysocki
2008-11-15 23:54 ` Jiri Kosina
2008-11-16 12:35 ` Rafael J. Wysocki
[not found] ` <alpine.LNX.1.10.0811160053580.19853-YCXOAqNspd+N3ZZ/Hiejyg@public.gmane.org>
2008-11-16 22:12 ` Andi Kleen
[not found] ` <20081111003117.GA10904-3rXA9MLqAseW/qJFnhkgxti2O/JbrIOy@public.gmane.org>
2008-11-12 14:31 ` Jiri Kosina
[not found] ` <alpine.LNX.1.10.0811121529240.32143-YCXOAqNspd+N3ZZ/Hiejyg@public.gmane.org>
2008-11-13 11:32 ` Andi Kleen
2008-11-13 12:30 ` Jiri Slaby
[not found] ` <491C1DFF.6000509-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-11-13 14:31 ` Andi Kleen
2008-11-13 15:54 ` Alan Stern
2008-11-13 21:10 ` [PATCH] HID: don't grab devices with no input Jiri Slaby
2008-11-13 21:37 ` Alan Stern
2008-11-13 21:37 ` Alan Stern
2008-11-13 22:05 ` Jiri Slaby
2008-11-13 22:09 ` [PATCH 1/1 v2] DRM: fix radeon suspend/resume oops Jiri Slaby
2008-11-13 22:11 ` Jiri Slaby
2008-11-13 22:10 ` [PATCH 1/1 v2] HID: don't grab devices with no input Jiri Slaby
2008-11-14 11:02 ` Jiri Kosina
2008-11-14 13:17 ` Andi Kleen
2008-11-14 13:09 ` Jiri Kosina
2008-11-13 22:22 ` Andi Kleen [this message]
2008-11-13 22:14 ` [PATCH] " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113222200.GD3810@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.