From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [RFC v9][PATCH 12/13] Checkpoint multiple processes Date: Thu, 13 Nov 2008 21:41:30 -0600 Message-ID: <20081114034130.GA14171@us.ibm.com> References: <1226335060-7061-1-git-send-email-orenl@cs.columbia.edu> <1226335060-7061-13-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1226335060-7061-13-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oren Laadan Cc: Andrew Morton , Linus Torvalds , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , Dave Hansen , Ingo Molnar , "H. Peter Anvin" , Alexander Viro List-Id: linux-api@vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > Checkpointing of multiple processes works by recording the tasks tree > structure below a given task (usually this task is the container init). > > For a given task, do a DFS scan of the tasks tree and collect them > into an array (keeping a reference to each task). Using DFS simplifies > the recreation of tasks either in user space or kernel space. For each > task collected, test if it can be checkpointed, and save its pid, tgid, > and ppid. > > The actual work is divided into two passes: a first scan counts the > tasks, then memory is allocated and a second scan fills the array. > > The logic is suitable for creation of processes during restart either > in userspace or by the kernel. > > Currently we ignore threads and zombies, as well as session ids. > > Signed-off-by: Oren Laadan Looks good. Acked-by: Serge Hallyn thanks, -serge -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbYKNDlp (ORCPT ); Thu, 13 Nov 2008 22:41:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751278AbYKNDlf (ORCPT ); Thu, 13 Nov 2008 22:41:35 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:60480 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbYKNDle (ORCPT ); Thu, 13 Nov 2008 22:41:34 -0500 Date: Thu, 13 Nov 2008 21:41:30 -0600 From: "Serge E. Hallyn" To: Oren Laadan Cc: Andrew Morton , Linus Torvalds , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, Thomas Gleixner , Dave Hansen , Ingo Molnar , "H. Peter Anvin" , Alexander Viro Subject: Re: [RFC v9][PATCH 12/13] Checkpoint multiple processes Message-ID: <20081114034130.GA14171@us.ibm.com> References: <1226335060-7061-1-git-send-email-orenl@cs.columbia.edu> <1226335060-7061-13-git-send-email-orenl@cs.columbia.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1226335060-7061-13-git-send-email-orenl@cs.columbia.edu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Oren Laadan (orenl@cs.columbia.edu): > Checkpointing of multiple processes works by recording the tasks tree > structure below a given task (usually this task is the container init). > > For a given task, do a DFS scan of the tasks tree and collect them > into an array (keeping a reference to each task). Using DFS simplifies > the recreation of tasks either in user space or kernel space. For each > task collected, test if it can be checkpointed, and save its pid, tgid, > and ppid. > > The actual work is divided into two passes: a first scan counts the > tasks, then memory is allocated and a second scan fills the array. > > The logic is suitable for creation of processes during restart either > in userspace or by the kernel. > > Currently we ignore threads and zombies, as well as session ids. > > Signed-off-by: Oren Laadan Looks good. Acked-by: Serge Hallyn thanks, -serge From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mAE3eqHZ014524 for ; Thu, 13 Nov 2008 20:40:52 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAE3fW22158924 for ; Thu, 13 Nov 2008 20:41:32 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAE3fVP7003890 for ; Thu, 13 Nov 2008 20:41:32 -0700 Date: Thu, 13 Nov 2008 21:41:30 -0600 From: "Serge E. Hallyn" Subject: Re: [RFC v9][PATCH 12/13] Checkpoint multiple processes Message-ID: <20081114034130.GA14171@us.ibm.com> References: <1226335060-7061-1-git-send-email-orenl@cs.columbia.edu> <1226335060-7061-13-git-send-email-orenl@cs.columbia.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1226335060-7061-13-git-send-email-orenl@cs.columbia.edu> Sender: owner-linux-mm@kvack.org Return-Path: To: Oren Laadan Cc: Andrew Morton , Linus Torvalds , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, Thomas Gleixner , Dave Hansen , Ingo Molnar , "H. Peter Anvin" , Alexander Viro List-ID: Quoting Oren Laadan (orenl@cs.columbia.edu): > Checkpointing of multiple processes works by recording the tasks tree > structure below a given task (usually this task is the container init). > > For a given task, do a DFS scan of the tasks tree and collect them > into an array (keeping a reference to each task). Using DFS simplifies > the recreation of tasks either in user space or kernel space. For each > task collected, test if it can be checkpointed, and save its pid, tgid, > and ppid. > > The actual work is divided into two passes: a first scan counts the > tasks, then memory is allocated and a second scan fills the array. > > The logic is suitable for creation of processes during restart either > in userspace or by the kernel. > > Currently we ignore threads and zombies, as well as session ids. > > Signed-off-by: Oren Laadan Looks good. Acked-by: Serge Hallyn thanks, -serge -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org