All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Ilya Yanok <yanok@emcraft.com>,
	Detlev Zundel <dzu@denx.de>, Wolfgang Denk <wd@denx.de>
Subject: Re: [PATCH] katmai.dts: extend DMA ranges; add dma/sysace nodes
Date: Thu, 13 Nov 2008 22:00:01 -0700	[thread overview]
Message-ID: <20081114050001.GA15181@secretlab.ca> (raw)
In-Reply-To: <20081113064533.77eccc1b@zod.rchland.ibm.com>

On Thu, Nov 13, 2008 at 06:45:33AM -0500, Josh Boyer wrote:
> On Thu, 13 Nov 2008 11:49:14 +0300
> Yuri Tikhonov <yur@emcraft.com> wrote:
> > +		sysacecf@4fe000000 {
> > +			compatible = "xlnx,opb-sysace-1.00.b";
> 
> Odd.  This isn't a xilinx board by any means.  This should probably
> look something like:
> 
> 	compatible = "amcc,sysace-440spe", "xlnx,opb-sysace-1.00.b";

Actually, if there is a sysace, it is definitely a xilinx part.  It
won't be on the SoC.  However, compatible = "xlnx,opb-sysace-1.00.b"
isn't really accurate.  It should really be compatible = "xlnx,sysace"
and the driver modified to accept this string.  "xlnx,opb-sysace-1.00.b"
is an FPGA block used to interface to the system ace which is
definitely not in use here.

So while it does get things to work, it is not a clean description of
the hardware.

g.

  reply	other threads:[~2008-11-14  5:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13  8:49 [PATCH] katmai.dts: extend DMA ranges; add dma/sysace nodes Yuri Tikhonov
2008-11-13  9:25 ` Benjamin Herrenschmidt
2008-11-14  4:45   ` Re[2]: " Yuri Tikhonov
2008-11-14  5:41     ` Benjamin Herrenschmidt
     [not found]       ` <1767195957.20081127032002@emcraft.com>
2008-11-27  0:26         ` Re[4]: " Yuri Tikhonov
2008-11-27  0:42           ` Benjamin Herrenschmidt
2008-11-27  0:59             ` Re[6]: " Yuri Tikhonov
2008-11-27  4:07               ` Benjamin Herrenschmidt
2008-11-13 11:45 ` Josh Boyer
2008-11-14  5:00   ` Grant Likely [this message]
2008-11-14  5:27     ` Re[2]: " Yuri Tikhonov
2008-11-14  5:30       ` Grant Likely
2008-11-14  5:21   ` Yuri Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081114050001.GA15181@secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=dzu@denx.de \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=wd@denx.de \
    --cc=yanok@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.