From: Mark Brown <broonie@sirena.org.uk>
To: Christian Pellegrin <chripell@gmail.com>
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.arm.linux.org.uk,
Christian Pellegrin <chripell@fsfe.org>
Subject: Re: [PATCH RESEND 1/2] ALSA SOC driver for s3c24xx with uda134x
Date: Fri, 14 Nov 2008 11:03:42 +0000 [thread overview]
Message-ID: <20081114110342.GE21573@sirena.org.uk> (raw)
In-Reply-To: <12265909162051-git-send-email-chripell@gmail.com>
On Thu, Nov 13, 2008 at 04:41:56PM +0100, Christian Pellegrin wrote:
This looks OK from an ASoC point of view but one small issue...
> + s3c24xx_uda134x_l3_pins = pdev->dev.platform_data;
> + if (s3c24xx_uda134x_l3_pins == NULL) {
> + printk(KERN_ERR "S3C24XX_UDA134X SoC Audio: "
> + "unable to find platform data\n");
> + return -ENODEV;
> + }
> + s3c24xx_uda134x.power = s3c24xx_uda134x_l3_pins->power;
> + s3c24xx_uda134x.model = s3c24xx_uda134x_l3_pins->model;
> + gpio_direction_output(s3c24xx_uda134x_l3_pins->l3_data, 0);
> + gpio_direction_output(s3c24xx_uda134x_l3_pins->l3_clk, 0);
> + gpio_direction_output(s3c24xx_uda134x_l3_pins->l3_mode, 0);
You should request the GPIOs with gpio_request() before using them (and
then free them with gpio_free() when the driver exits).
next prev parent reply other threads:[~2008-11-14 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 15:41 [PATCH RESEND 1/2] ALSA SOC driver for s3c24xx with uda134x Christian Pellegrin
2008-11-14 11:03 ` Mark Brown [this message]
2008-11-14 16:32 ` christian pellegrin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114110342.GE21573@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=chripell@fsfe.org \
--cc=chripell@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.