From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 0/16 v6] PCI: Linux kernel SR-IOV support Date: Fri, 14 Nov 2008 10:39:14 -0800 Message-ID: <20081114183914.GA23801@kroah.com> References: <43F901BD926A4E43B106BF17856F07552F2E8F06@orsmsx508.amr.corp.intel.com> <9832F13BD22FB94A829F798DA4A82805018C18EE41@pdsmsx503.ccr.corp.intel.com> <43F901BD926A4E43B106BF17856F07552F2E8F20@orsmsx508.amr.corp.intel.com> <491D2F23.1080005@intel.com> <20081114174029.GH22980@kroah.com> <43F901BD926A4E43B106BF17856F07552F33C5F8@orsmsx508.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Zhao, Yu" , "Dong, Eddie" , "kvm@vger.kernel.org" , "Barnes, Jesse" , "Ronciak, John" , "Nakajima, Jun" , "Yu, Wilfred" , "Li, Xin B" , "Li, Susie" To: "Rose, Gregory V" Return-path: Received: from kroah.org ([198.145.64.141]:51537 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753813AbYKNSmc (ORCPT ); Fri, 14 Nov 2008 13:42:32 -0500 Content-Disposition: inline In-Reply-To: <43F901BD926A4E43B106BF17856F07552F33C5F8@orsmsx508.amr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 14, 2008 at 09:48:15AM -0800, Rose, Gregory V wrote: > It's not upstream yet. However, if you grep through for > CONFIG_PCI_IOV you'll see all the relevant code in those sections. Wouldn't it make more sense for the IOV code to be reworked to not require #ifdefs in a driver? There seems to be a bit too much #ifdef code in this driver right now :( What is the status of submitting it upstream and getting netdev review of it? thanks, greg k-h