[Qemu-devel] Re: [Bochs-developers] [PATCH v3 2/6] Add S3 state to DSDT. Handleresume event in the BIOS.

[Gleb Natapov <gleb@redhat.com>]

On Sat, Nov 15, 2008 at 06:43:44PM +0100, Sebastian Herbszt wrote:
> Any reason not to immediately return if the wakeup vector is NULL?
>
> @@ -2092,8 +2100,8 @@ void rombios32_init(uint32_t *s3_resume_
>             /* redirect bios read access to RAM */
>             pci_for_each_device(find_440fx);
>             bios_lock_shadow_ram(); /* bios is already copied */
> -            return;
>         }
> +        return;
>     }
>
>     pci_bios_init();
The idea was that if wakeup vector is NULL we proceed with regular
boot process. After changing S3 resume to not do normal POST, but 
jump to s3_post instead that's no longer works. Lets return here earlier
as you suggest and s3_resume can jump to normal POST if resume vector is
NULL.

--
			Gleb.