From: Andrew Morton <akpm@linux-foundation.org>
To: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
Cc: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
balbir@linux.vnet.ibm.com, "Lai Jiangshan" <laijs@cn.fujitsu.com>,
"Arjan van de Ven" <arjan@infradead.org>,
"Dave Airlie" <airlied@gmail.com>,
"David Miller" <davem@davemloft.net>,
menage@google.com, jens.axboe@oracle.com, jack@suse.cz,
jes@sgi.com, linux-kernel@vger.kernel.org, dada1@cosmosbay.com,
"Alexey Dobriyan" <adobriyan@gmail.com>
Subject: Re: [PATCH 1/7] mm: introduce simple_malloc()/simple_free()
Date: Sun, 16 Nov 2008 23:13:01 -0800 [thread overview]
Message-ID: <20081116231301.c6b0da95.akpm@linux-foundation.org> (raw)
In-Reply-To: <2f11576a0811162243r7527d271ya8ab2fc3a9be9f7d@mail.gmail.com>
On Mon, 17 Nov 2008 15:43:59 +0900 "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com> wrote:
> >> > (I'll rename simple_malloc/simple_free to kvmalloc/kvfree)
> >> >
> >>
> >> I would prefer to find a way to say that one cannot select gfp_mask with this API.
> >>
> > I think gfp_mask must be passed explicitly.
>
> Agreed.
It would only make sense if __vmalloc() can be called in atomic contexts.
__vmalloc() cannot be called from irq contexts due to it taking
non-irq-safe spinlocks.
__vmalloc() kinda looks like it could be called from non-irq atomic
contexts with GFP_ATOMIC, but I think it lies. For example,
pud_alloc_one/pmd_alloc_one/etc use hard-wired GFP_KERNEL.
In which case this new allocation function can only be called from
contexts where GFP_KERNEL can be used, hence we don't need to pass that
in - it would be misleading to do so.
In fact it's not immediately clear why __vmalloc() takes a gfp_t
argument either?
next prev parent reply other threads:[~2008-11-17 7:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 4:33 [PATCH 1/7] mm: introduce simple_malloc()/simple_free() Lai Jiangshan
2008-11-16 4:49 ` Alexey Dobriyan
2008-11-16 8:14 ` David Miller
2008-11-16 18:42 ` KOSAKI Motohiro
2008-11-16 4:52 ` Arjan van de Ven
2008-11-16 5:03 ` Andrew Morton
2008-11-16 5:35 ` Lai Jiangshan
2008-11-16 5:47 ` Andrew Morton
2008-11-16 5:53 ` Arjan van de Ven
2008-11-16 6:08 ` Eric Dumazet
2008-11-16 8:23 ` David Miller
2008-11-16 8:21 ` David Miller
2008-11-16 8:19 ` David Miller
2008-11-16 18:57 ` Arjan van de Ven
2008-11-16 21:39 ` Dave Airlie
2008-11-16 21:51 ` Arjan van de Ven
2008-11-16 22:42 ` Dave Airlie
2008-11-17 2:08 ` Lai Jiangshan
2008-11-17 4:53 ` Balbir Singh
2008-11-17 5:25 ` KAMEZAWA Hiroyuki
2008-11-17 6:43 ` KOSAKI Motohiro
2008-11-17 7:13 ` Andrew Morton [this message]
2008-11-17 7:15 ` David Miller
2008-11-17 8:10 ` KOSAKI Motohiro
2008-11-17 8:24 ` Balbir Singh
2008-11-18 4:39 ` Nick Piggin
2008-11-18 5:16 ` Lai Jiangshan
2008-11-17 4:46 ` Balbir Singh
2008-11-17 4:43 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081116231301.c6b0da95.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=airlied@gmail.com \
--cc=arjan@infradead.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=jes@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.