All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: netdev@vger.kernel.org
Cc: Mark McLoughlin <markmc@redhat.com>
Subject: [PATCH 2/3] virtio_net: hook up the set-tso ethtool op
Date: Mon, 17 Nov 2008 13:46:08 +1030	[thread overview]
Message-ID: <200811171346.09039.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200811171344.57410.rusty@rustcorp.com.au>

From: Mark McLoughlin <markmc@redhat.com>

Seems like an oversight that we have set-tx-csum and set-sg hooked
up, but not set-tso.

Also leads to the strange situation that if you e.g. disable tx-csum,
then tso doesn't get disabled.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 drivers/net/virtio_net.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index cca6435..79b59cc 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -612,6 +612,7 @@ static int virtnet_set_tx_csum(struct net_device *dev, u32 data)
 static struct ethtool_ops virtnet_ethtool_ops = {
 	.set_tx_csum = virtnet_set_tx_csum,
 	.set_sg = ethtool_op_set_sg,
+	.set_tso = ethtool_op_set_tso,
 };
 
 static int virtnet_probe(struct virtio_device *vdev)


  reply	other threads:[~2008-11-17  3:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  3:14 [PATCH 1/3] virtio_net: Recycle some more rx buffer pages Rusty Russell
2008-11-17  3:16 ` Rusty Russell [this message]
2008-11-17  3:17   ` [PATCH 3/3] virtio_net: VIRTIO_NET_F_MSG_RXBUF (imprive rcv buffer allocation) Rusty Russell
2008-11-17  6:42     ` David Miller
2008-11-17  6:40   ` [PATCH 2/3] virtio_net: hook up the set-tso ethtool op David Miller
2008-11-17  3:45 ` [PATCH 1/3] virtio_net: Recycle some more rx buffer pages David Miller
2008-11-17  6:40   ` David Miller
2008-11-17  7:08     ` Rusty Russell
2008-11-17  7:14       ` David Miller
2008-11-17  7:05   ` Rusty Russell
2008-11-17  7:08     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811171346.09039.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=markmc@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.