All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc: do not goto to the next line
Date: Mon, 17 Nov 2008 15:23:02 +0000	[thread overview]
Message-ID: <20081117152302.GC14976@hack.voiplan.pt> (raw)
In-Reply-To: <1226934652-23028-1-git-send-email-den@openvz.org>

On Mon, Nov 17, 2008 at 06:10:52PM +0300, Denis V. Lunev wrote:
>Signed-off-by: Denis V. Lunev <den@openvz.org>
>---
> ipc/sem.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/ipc/sem.c b/ipc/sem.c
>index 0821224..b91d455 100644
>--- a/ipc/sem.c
>+++ b/ipc/sem.c
>@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
> 	if (timeout && jiffies_left == 0)
> 		error = -EAGAIN;
> 	list_del(&queue.list);
>-	goto out_unlock_free;
> 
> out_unlock_free:
> 	sem_unlock(sma);

Aha, this goto is obviously useless. :)

If you need, 
Reviewed-by: WANG Cong <wangcong@zeuux.org>


-- 
"Sometimes the only way to stay sane is to go a little crazy."


      reply	other threads:[~2008-11-17 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17 15:10 [PATCH] ipc: do not goto to the next line Denis V. Lunev
2008-11-17 15:23 ` Américo Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081117152302.GC14976@hack.voiplan.pt \
    --to=xiyou.wangcong@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=den@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.