From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
Doug Chapman <doug.chapman@hp.com>,
Frank Mayhar <fmayhar@google.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fix the racy usage of ->signal in account_group_xxx/run_posix_cpu_timers
Date: Mon, 17 Nov 2008 16:50:09 +0100 [thread overview]
Message-ID: <20081117155009.GA12081@elte.hu> (raw)
In-Reply-To: <20081117143947.GA5360@redhat.com>
* Oleg Nesterov <oleg@redhat.com> wrote:
> Another stupid patch for 2.6.28 until we find the good fix.
>
> Contrary to ad474caca3e2a0550b7ce0706527ad5ab389a4d4 changelog,
> other acct_group_xxx() helpers can be called after exit_notify() by
> timer tick. Thanks to Roland for pointing out this. Somehow I missed
> this simple fact when I read the original patch, and I am afraid I
> confused Frank during the discussion. Sorry.
>
> Fortunately, these helpers work with current, we can check
> ->exit_state to ensure that ->signal can't go away under us.
>
> Also, add the comment and compiler barrier to
> account_group_exec_runtime(), to make sure we load ->signal only
> once.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
applied to tip/sched/urgent, thanks Oleg.
Ingo
prev parent reply other threads:[~2008-11-17 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 14:39 [PATCH 1/3] fix the racy usage of ->signal in account_group_xxx/run_posix_cpu_timers Oleg Nesterov
2008-11-17 15:50 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117155009.GA12081@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=doug.chapman@hp.com \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.